Skip to content

Commit e6f7da7

Browse files
committed
the order of keys is stable now (the same as in the input), fix test cases
1 parent 9c2910f commit e6f7da7

File tree

4 files changed

+7
-10
lines changed

4 files changed

+7
-10
lines changed

pandas/tests/arrays/boolean/test_function.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -77,18 +77,18 @@ def test_ufunc_reduce_raises(values):
7777
def test_value_counts_na():
7878
arr = pd.array([True, False, pd.NA], dtype="boolean")
7979
result = arr.value_counts(dropna=False)
80-
expected = pd.Series([1, 1, 1], index=[False, True, pd.NA], dtype="Int64")
80+
expected = pd.Series([1, 1, 1], index=[True, False, pd.NA], dtype="Int64")
8181
tm.assert_series_equal(result, expected)
8282

8383
result = arr.value_counts(dropna=True)
84-
expected = pd.Series([1, 1], index=[False, True], dtype="Int64")
84+
expected = pd.Series([1, 1], index=[True, False], dtype="Int64")
8585
tm.assert_series_equal(result, expected)
8686

8787

8888
def test_value_counts_with_normalize():
8989
s = pd.Series([True, False, pd.NA], dtype="boolean")
9090
result = s.value_counts(normalize=True)
91-
expected = pd.Series([1, 1], index=[False, True], dtype="Float64") / 2
91+
expected = pd.Series([1, 1], index=[True, False], dtype="Float64") / 2
9292
tm.assert_series_equal(result, expected)
9393

9494

pandas/tests/arrays/test_datetimes.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ def test_value_counts_preserves_tz(self):
281281

282282
arr[-2] = pd.NaT
283283
result = arr.value_counts()
284-
expected = pd.Series([1, 4, 2], index=[pd.NaT, dti[0], dti[1]])
284+
expected = pd.Series([4, 2, 1], index=[dti[0], dti[1], pd.NaT])
285285
tm.assert_series_equal(result, expected)
286286

287287
@pytest.mark.parametrize("method", ["pad", "backfill"])

pandas/tests/series/methods/test_value_counts.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ def test_value_counts_categorical_with_nan(self):
195195
(
196196
Series(range(3), index=[True, False, np.nan]).index,
197197
False,
198-
Series([1, 1, 1], index=[pd.NA, False, True]),
198+
Series([1, 1, 1], index=[np.nan, True, False]),
199199
),
200200
],
201201
)

pandas/tests/test_algos.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import pytest
77

88
from pandas._libs import algos as libalgos, hashtable as ht
9-
from pandas.compat import IS64
109
from pandas.compat.numpy import np_array_datetime64_compat
1110
import pandas.util._test_decorators as td
1211

@@ -1273,12 +1272,10 @@ def test_value_counts_uint64(self):
12731272
tm.assert_series_equal(result, expected)
12741273

12751274
arr = np.array([-1, 2 ** 63], dtype=object)
1276-
expected = Series([1, 1], index=[2 ** 63, -1])
1275+
expected = Series([1, 1], index=[-1, 2 ** 63])
12771276
result = algos.value_counts(arr)
12781277

1279-
# 32-bit linux has a different ordering
1280-
if IS64:
1281-
tm.assert_series_equal(result, expected)
1278+
tm.assert_series_equal(result, expected)
12821279

12831280

12841281
class TestDuplicated:

0 commit comments

Comments
 (0)