Skip to content

Commit e6ec1d9

Browse files
committed
TST : Renamed and changed the location of unittests.
1 parent e15e17e commit e6ec1d9

File tree

3 files changed

+51
-46
lines changed

3 files changed

+51
-46
lines changed

doc/source/whatsnew/v0.18.2.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -149,4 +149,4 @@ Bug Fixes
149149
- Bug in ``NaT`` - ``Period`` raises ``AttributeError`` (:issue:`13071`)
150150
- Bug in ``Period`` addition raises ``TypeError`` if ``Period`` is on right hand side (:issue:`13069`)
151151
- Bug in ``pd.set_eng_float_format()`` that would prevent NaN's from formatting (:issue:`11981`)
152-
- Fixed the bug in ``DataFrame.align()`` which was giving wrong output when supplied with the ``join`` argument. (:issue:`13194`)
152+
- Fixed the bug in ``DataFrame.align()`` which was giving wrong output when supplied with the ``join`` argument. Earlier, upon supplying value of join argument as any of the four('outer', 'inner', 'left', 'right' ), align() was giving erraneous output. The problem was identified to be in pandas/core/generic.py and has been subsequently fixed. (:issue:`13194`)

pandas/tests/frame/test_axis_select_reindex.py

+50
Original file line numberDiff line numberDiff line change
@@ -880,3 +880,53 @@ def test_reindex_multi(self):
880880
expected = df.reindex([0, 1]).reindex(columns=['a', 'b'])
881881

882882
assert_frame_equal(result, expected)
883+
884+
def test_align_broadcast_axis(self):
885+
# GH 13194
886+
# For 'outer' join
887+
df = DataFrame(np.array([[1., 2.], [3., 4.]]), columns=list('AB'))
888+
ts = Series([5., 6., 7.])
889+
result = df.align(ts, join='outer', axis=0, broadcast_axis=1)
890+
result1 = DataFrame(result[0])
891+
result2 = DataFrame(result[1])
892+
expected1 = DataFrame(np.array([[1., 2.], [3., 4.],
893+
[pd.np.nan, pd.np.nan]]),
894+
columns=list('AB'))
895+
expected2 = DataFrame(np.array([[5., 5.], [6., 6.], [7., 7.]]),
896+
columns=list('AB'))
897+
assert_frame_equal(result1, expected1)
898+
assert_frame_equal(result2, expected2)
899+
900+
# For 'inner' join
901+
result = df.align(ts, join='inner', axis=0, broadcast_axis=1)
902+
result1 = DataFrame(result[0])
903+
result2 = DataFrame(result[1])
904+
expected1 = DataFrame(np.array([[1., 2.], [3., 4.]]),
905+
columns=list('AB'))
906+
expected2 = DataFrame(np.array([[5., 5.], [6., 6.]]),
907+
columns=list('AB'))
908+
assert_frame_equal(result1, expected1)
909+
assert_frame_equal(result2, expected2)
910+
911+
# For 'left' join
912+
result = df.align(ts, join='left', axis=0, broadcast_axis=1)
913+
result1 = DataFrame(result[0])
914+
result2 = DataFrame(result[1])
915+
expected1 = DataFrame(np.array([[1., 2.], [3., 4.]]),
916+
columns=list('AB'))
917+
expected2 = DataFrame(np.array([[5., 5.], [6., 6.]]),
918+
columns=list('AB'))
919+
assert_frame_equal(result1, expected1)
920+
assert_frame_equal(result2, expected2)
921+
922+
# For 'right' join
923+
result = df.align(ts, join='right', axis=0, broadcast_axis=1)
924+
result1 = DataFrame(result[0])
925+
result2 = DataFrame(result[1])
926+
expected1 = DataFrame(np.array([[1., 2.], [3., 4.],
927+
[pd.np.nan, pd.np.nan]]),
928+
columns=list('AB'))
929+
expected2 = DataFrame(np.array([[5., 5.], [6., 6.], [7., 7.]]),
930+
columns=list('AB'))
931+
assert_frame_equal(result1, expected1)
932+
assert_frame_equal(result2, expected2)

pandas/tests/test_generic.py

-45
Original file line numberDiff line numberDiff line change
@@ -1874,51 +1874,6 @@ def test_pipe_panel(self):
18741874
with tm.assertRaises(ValueError):
18751875
result = wp.pipe((f, 'y'), x=1, y=1)
18761876

1877-
def test_align_joins(self):
1878-
df = DataFrame(np.array([[1., 2.], [3., 4.]]), columns=list('AB'))
1879-
ts = Series([5., 6., 7.])
1880-
check = df.align(ts, join='outer', axis=0, broadcast_axis=1)
1881-
df1 = DataFrame(check[0])
1882-
df2 = DataFrame(check[1])
1883-
expected1 = DataFrame(np.array([[1., 2.], [3., 4.],
1884-
[pd.np.nan, pd.np.nan]]),
1885-
columns=list('AB'))
1886-
expected2 = DataFrame(np.array([[5., 5.], [6., 6.], [7., 7.]]),
1887-
columns=list('AB'))
1888-
assert_frame_equal(df1, expected1)
1889-
assert_frame_equal(df2, expected2)
1890-
1891-
check = df.align(ts, join='inner', axis=0, broadcast_axis=1)
1892-
df1 = DataFrame(check[0])
1893-
df2 = DataFrame(check[1])
1894-
expected1 = DataFrame(np.array([[1., 2.], [3., 4.]]),
1895-
columns=list('AB'))
1896-
expected2 = DataFrame(np.array([[5., 5.], [6., 6.]]),
1897-
columns=list('AB'))
1898-
assert_frame_equal(df1, expected1)
1899-
assert_frame_equal(df2, expected2)
1900-
1901-
check = df.align(ts, join='left', axis=0, broadcast_axis=1)
1902-
df1 = DataFrame(check[0])
1903-
df2 = DataFrame(check[1])
1904-
expected1 = DataFrame(np.array([[1., 2.], [3., 4.]]),
1905-
columns=list('AB'))
1906-
expected2 = DataFrame(np.array([[5., 5.], [6., 6.]]),
1907-
columns=list('AB'))
1908-
assert_frame_equal(df1, expected1)
1909-
assert_frame_equal(df2, expected2)
1910-
1911-
check = df.align(ts, join='right', axis=0, broadcast_axis=1)
1912-
df1 = DataFrame(check[0])
1913-
df2 = DataFrame(check[1])
1914-
expected1 = DataFrame(np.array([[1., 2.], [3., 4.],
1915-
[pd.np.nan, pd.np.nan]]),
1916-
columns=list('AB'))
1917-
expected2 = DataFrame(np.array([[5., 5.], [6., 6.], [7., 7.]]),
1918-
columns=list('AB'))
1919-
assert_frame_equal(df1, expected1)
1920-
assert_frame_equal(df2, expected2)
1921-
19221877

19231878
if __name__ == '__main__':
19241879
nose.runmodule(argv=[__file__, '-vvs', '-x', '--pdb', '--pdb-failure'],

0 commit comments

Comments
 (0)