BUG: allow conversion of Timestamp and Timedelta to string in astype (GH 9757)

Author: evanpw

doc/source/whatsnew/v0.16.1.txt

@@ -66,3 +66,4 @@ Bug Fixes
 
 
 - Bug in ``Series.quantile`` on empty Series of type ``Datetime`` or ``Timedelta`` (:issue:`9675`)
+- Bug causing ``astype(str)`` to fail for dtype ``datetime64`` or ``timedelta64`` (:issue:`9757`)

pandas/core/common.py

@@ -2636,7 +2636,12 @@ def _astype_nansafe(arr, dtype, copy=True):
     if not isinstance(dtype, np.dtype):
         dtype = _coerce_to_dtype(dtype)
 
-    if is_datetime64_dtype(arr):
+    if issubclass(dtype.type, compat.text_type):
+        # in Py3 that's str, in Py2 that's unicode
+        return lib.astype_unicode(arr.ravel()).reshape(arr.shape)
+    elif issubclass(dtype.type, compat.string_types):
+        return lib.astype_str(arr.ravel()).reshape(arr.shape)
+    elif is_datetime64_dtype(arr):
         if dtype == object:
             return tslib.ints_to_pydatetime(arr.view(np.int64))
         elif dtype == np.int64:
@@ -2674,11 +2679,6 @@ def _astype_nansafe(arr, dtype, copy=True):
     elif arr.dtype == np.object_ and np.issubdtype(dtype.type, np.integer):
         # work around NumPy brokenness, #1987
         return lib.astype_intsafe(arr.ravel(), dtype).reshape(arr.shape)
-    elif issubclass(dtype.type, compat.text_type):
-        # in Py3 that's str, in Py2 that's unicode
-        return lib.astype_unicode(arr.ravel()).reshape(arr.shape)
-    elif issubclass(dtype.type, compat.string_types):
-        return lib.astype_str(arr.ravel()).reshape(arr.shape)
 
     if copy:
         return arr.astype(dtype)

pandas/tests/test_series.py

@@ -5433,6 +5433,15 @@ def test_astype_str(self):
                 expec = s.map(compat.text_type)
                 assert_series_equal(res, expec)
 
+        # GH9757
+        ts = Series([Timestamp('2010-01-04 00:00:00')])
+        ts = ts.astype(str)
+        self.assertEqual(ts.dtype, np.object_)
+
+        td = Series([Timedelta(1, unit='d')])
+        td = td.astype(str)
+        self.assertEqual(td.dtype, np.object_)
+
     def test_astype_unicode(self):
 
         # GH7758