Skip to content

Commit e15a1ce

Browse files
committed
BUG: Fix skipna default value in method signatures
Set `skipna` default values to `True` so that the value matches the purpose of the variable and its docstring.
1 parent ba64ab5 commit e15a1ce

File tree

1 file changed

+25
-31
lines changed

1 file changed

+25
-31
lines changed

pandas/core/generic.py

+25-31
Original file line numberDiff line numberDiff line change
@@ -10387,15 +10387,13 @@ def _stat_function_ddof(
1038710387
name: str,
1038810388
func,
1038910389
axis=None,
10390-
skipna=None,
10390+
skipna=True,
1039110391
level=None,
1039210392
ddof=1,
1039310393
numeric_only=None,
1039410394
**kwargs,
1039510395
):
1039610396
nv.validate_stat_ddof_func((), kwargs, fname=name)
10397-
if skipna is None:
10398-
skipna = True
1039910397
if axis is None:
1040010398
axis = self._stat_axis_number
1040110399
if level is not None:
@@ -10414,21 +10412,21 @@ def _stat_function_ddof(
1041410412
)
1041510413

1041610414
def sem(
10417-
self, axis=None, skipna=None, level=None, ddof=1, numeric_only=None, **kwargs
10415+
self, axis=None, skipna=True, level=None, ddof=1, numeric_only=None, **kwargs
1041810416
):
1041910417
return self._stat_function_ddof(
1042010418
"sem", nanops.nansem, axis, skipna, level, ddof, numeric_only, **kwargs
1042110419
)
1042210420

1042310421
def var(
10424-
self, axis=None, skipna=None, level=None, ddof=1, numeric_only=None, **kwargs
10422+
self, axis=None, skipna=True, level=None, ddof=1, numeric_only=None, **kwargs
1042510423
):
1042610424
return self._stat_function_ddof(
1042710425
"var", nanops.nanvar, axis, skipna, level, ddof, numeric_only, **kwargs
1042810426
)
1042910427

1043010428
def std(
10431-
self, axis=None, skipna=None, level=None, ddof=1, numeric_only=None, **kwargs
10429+
self, axis=None, skipna=True, level=None, ddof=1, numeric_only=None, **kwargs
1043210430
):
1043310431
return self._stat_function_ddof(
1043410432
"std", nanops.nanstd, axis, skipna, level, ddof, numeric_only, **kwargs
@@ -10440,7 +10438,7 @@ def _stat_function(
1044010438
name: str,
1044110439
func,
1044210440
axis=None,
10443-
skipna=None,
10441+
skipna=True,
1044410442
level=None,
1044510443
numeric_only=None,
1044610444
**kwargs,
@@ -10449,8 +10447,6 @@ def _stat_function(
1044910447
nv.validate_median((), kwargs)
1045010448
else:
1045110449
nv.validate_stat_func((), kwargs, fname=name)
10452-
if skipna is None:
10453-
skipna = True
1045410450
if axis is None:
1045510451
axis = self._stat_axis_number
1045610452
if level is not None:
@@ -10468,32 +10464,32 @@ def _stat_function(
1046810464
func, name=name, axis=axis, skipna=skipna, numeric_only=numeric_only
1046910465
)
1047010466

10471-
def min(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10467+
def min(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1047210468
return self._stat_function(
1047310469
"min", nanops.nanmin, axis, skipna, level, numeric_only, **kwargs
1047410470
)
1047510471

10476-
def max(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10472+
def max(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1047710473
return self._stat_function(
1047810474
"max", nanops.nanmax, axis, skipna, level, numeric_only, **kwargs
1047910475
)
1048010476

10481-
def mean(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10477+
def mean(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1048210478
return self._stat_function(
1048310479
"mean", nanops.nanmean, axis, skipna, level, numeric_only, **kwargs
1048410480
)
1048510481

10486-
def median(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10482+
def median(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1048710483
return self._stat_function(
1048810484
"median", nanops.nanmedian, axis, skipna, level, numeric_only, **kwargs
1048910485
)
1049010486

10491-
def skew(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10487+
def skew(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1049210488
return self._stat_function(
1049310489
"skew", nanops.nanskew, axis, skipna, level, numeric_only, **kwargs
1049410490
)
1049510491

10496-
def kurt(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10492+
def kurt(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1049710493
return self._stat_function(
1049810494
"kurt", nanops.nankurt, axis, skipna, level, numeric_only, **kwargs
1049910495
)
@@ -10506,7 +10502,7 @@ def _min_count_stat_function(
1050610502
name: str,
1050710503
func,
1050810504
axis=None,
10509-
skipna=None,
10505+
skipna=True,
1051010506
level=None,
1051110507
numeric_only=None,
1051210508
min_count=0,
@@ -10518,8 +10514,6 @@ def _min_count_stat_function(
1051810514
nv.validate_prod((), kwargs)
1051910515
else:
1052010516
nv.validate_stat_func((), kwargs, fname=name)
10521-
if skipna is None:
10522-
skipna = True
1052310517
if axis is None:
1052410518
axis = self._stat_axis_number
1052510519
if level is not None:
@@ -10550,7 +10544,7 @@ def _min_count_stat_function(
1055010544
def sum(
1055110545
self,
1055210546
axis=None,
10553-
skipna=None,
10547+
skipna=True,
1055410548
level=None,
1055510549
numeric_only=None,
1055610550
min_count=0,
@@ -10563,7 +10557,7 @@ def sum(
1056310557
def prod(
1056410558
self,
1056510559
axis=None,
10566-
skipna=None,
10560+
skipna=True,
1056710561
level=None,
1056810562
numeric_only=None,
1056910563
min_count=0,
@@ -10690,7 +10684,7 @@ def mad(self, axis=None, skipna=None, level=None):
1069010684
def sem(
1069110685
self,
1069210686
axis=None,
10693-
skipna=None,
10687+
skipna=True,
1069410688
level=None,
1069510689
ddof=1,
1069610690
numeric_only=None,
@@ -10712,7 +10706,7 @@ def sem(
1071210706
def var(
1071310707
self,
1071410708
axis=None,
10715-
skipna=None,
10709+
skipna=True,
1071610710
level=None,
1071710711
ddof=1,
1071810712
numeric_only=None,
@@ -10735,7 +10729,7 @@ def var(
1073510729
def std(
1073610730
self,
1073710731
axis=None,
10738-
skipna=None,
10732+
skipna=True,
1073910733
level=None,
1074010734
ddof=1,
1074110735
numeric_only=None,
@@ -10815,7 +10809,7 @@ def cumprod(self, axis=None, skipna=True, *args, **kwargs):
1081510809
def sum(
1081610810
self,
1081710811
axis=None,
10818-
skipna=None,
10812+
skipna=True,
1081910813
level=None,
1082010814
numeric_only=None,
1082110815
min_count=0,
@@ -10840,7 +10834,7 @@ def sum(
1084010834
def prod(
1084110835
self,
1084210836
axis=None,
10843-
skipna=None,
10837+
skipna=True,
1084410838
level=None,
1084510839
numeric_only=None,
1084610840
min_count=0,
@@ -10863,7 +10857,7 @@ def prod(
1086310857
see_also="",
1086410858
examples="",
1086510859
)
10866-
def mean(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10860+
def mean(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1086710861
return NDFrame.mean(self, axis, skipna, level, numeric_only, **kwargs)
1086810862

1086910863
setattr(cls, "mean", mean)
@@ -10878,7 +10872,7 @@ def mean(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
1087810872
see_also="",
1087910873
examples="",
1088010874
)
10881-
def skew(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10875+
def skew(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1088210876
return NDFrame.skew(self, axis, skipna, level, numeric_only, **kwargs)
1088310877

1088410878
setattr(cls, "skew", skew)
@@ -10896,7 +10890,7 @@ def skew(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
1089610890
see_also="",
1089710891
examples="",
1089810892
)
10899-
def kurt(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10893+
def kurt(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1090010894
return NDFrame.kurt(self, axis, skipna, level, numeric_only, **kwargs)
1090110895

1090210896
setattr(cls, "kurt", kurt)
@@ -10913,7 +10907,7 @@ def kurt(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
1091310907
examples="",
1091410908
)
1091510909
def median(
10916-
self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs
10910+
self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs
1091710911
):
1091810912
return NDFrame.median(self, axis, skipna, level, numeric_only, **kwargs)
1091910913

@@ -10931,7 +10925,7 @@ def median(
1093110925
see_also=_stat_func_see_also,
1093210926
examples=_max_examples,
1093310927
)
10934-
def max(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10928+
def max(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1093510929
return NDFrame.max(self, axis, skipna, level, numeric_only, **kwargs)
1093610930

1093710931
setattr(cls, "max", max)
@@ -10948,7 +10942,7 @@ def max(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
1094810942
see_also=_stat_func_see_also,
1094910943
examples=_min_examples,
1095010944
)
10951-
def min(self, axis=None, skipna=None, level=None, numeric_only=None, **kwargs):
10945+
def min(self, axis=None, skipna=True, level=None, numeric_only=None, **kwargs):
1095210946
return NDFrame.min(self, axis, skipna, level, numeric_only, **kwargs)
1095310947

1095410948
setattr(cls, "min", min)

0 commit comments

Comments
 (0)