Deprivatize _get_range_parameters, grammar in whatsnew

Author: jschendel

doc/source/whatsnew/v0.21.0.txt

@@ -955,7 +955,7 @@ Conversion
 - Bug in ``Timedelta`` construction and arithmetic that would not propagate the ``Overflow`` exception (:issue:`17367`)
 - Bug in :meth:`~DataFrame.astype` converting to object dtype when passed extension type classes (`DatetimeTZDtype``, ``CategoricalDtype``) rather than instances. Now a ``TypeError`` is raised when a class is passed (:issue:`17780`).
 - Bug in :meth:`to_numeric` in which elements were not always being coerced to numeric when ``errors='coerce'`` (:issue:`17007`, :issue:`17125`)
-- Bug in ``DataFrame`` and ``Series`` constructors where ``range`` objects are converted ``int32`` dtype on Windows instead of ``int64`` (:issue:`16804`)
+- Bug in ``DataFrame`` and ``Series`` constructors where ``range`` objects are converted to ``int32`` dtype on Windows instead of ``int64`` (:issue:`16804`)
 
 Indexing
 ^^^^^^^^

pandas/compat/__init__.py

@@ -100,7 +100,7 @@ def signature(f):
                                            'varargs', 'keywords'])
         return argspec(args, defaults, varargs, keywords)
 
-    def _get_range_parameters(data):
+    def get_range_parameters(data):
         """Gets the start, stop, and step parameters from a range object"""
         return data.start, data.stop, data.step
 
@@ -150,7 +150,7 @@ def bytes_to_str(b, encoding='ascii'):
     def signature(f):
         return inspect.getargspec(f)
 
-    def _get_range_parameters(data):
+    def get_range_parameters(data):
         """Gets the start, stop, and step parameters from a range object"""
         # seems we only have indexing ops to infer
         # rather than direct accessors

pandas/core/indexes/range.py

@@ -10,7 +10,7 @@
     is_int64_dtype)
 
 from pandas import compat
-from pandas.compat import lrange, range, _get_range_parameters
+from pandas.compat import lrange, range, get_range_parameters
 from pandas.compat.numpy import function as nv
 from pandas.core.common import _all_none
 from pandas.core.indexes.base import Index, _index_shared_docs
@@ -113,7 +113,7 @@ def from_range(cls, data, name=None, dtype=None, **kwargs):
                 '{0}(...) must be called with object coercible to a '
                 'range, {1} was passed'.format(cls.__name__, repr(data)))
 
-        start, stop, step = _get_range_parameters(data)
+        start, stop, step = get_range_parameters(data)
         return RangeIndex(start, stop, step, dtype=dtype, name=name, **kwargs)
 
     @classmethod

pandas/core/series.py

@@ -61,7 +61,7 @@
 from pandas import compat
 from pandas.io.formats.terminal import get_terminal_size
 from pandas.compat import (
-    zip, u, OrderedDict, StringIO, range, _get_range_parameters)
+    zip, u, OrderedDict, StringIO, range, get_range_parameters)
 from pandas.compat.numpy import function as nv
 
 from pandas.core import accessor
@@ -3180,7 +3180,7 @@ def _try_cast(arr, take_fast_path):
 
     elif isinstance(data, range):
         # GH 16804
-        start, stop, step = _get_range_parameters(data)
+        start, stop, step = get_range_parameters(data)
         arr = np.arange(start, stop, step, dtype='int64')
         subarr = _try_cast(arr, False)
     else:

pandas/tests/test_compat.py

@@ -6,7 +6,7 @@
 import pytest
 from pandas.compat import (range, zip, map, filter, lrange, lzip, lmap,
                            lfilter, builtins, iterkeys, itervalues, iteritems,
-                           next, _get_range_parameters, PY2)
+                           next, get_range_parameters, PY2)
 
 
 class TestBuiltinIterators(object):
@@ -85,7 +85,7 @@ def test_get_range_parameters(self, start, stop, step):
         else:
             start_expected, stop_expected, step_expected = start, stop, step
 
-        start_result, stop_result, step_result = _get_range_parameters(rng)
+        start_result, stop_result, step_result = get_range_parameters(rng)
         assert start_result == start_expected
         assert stop_result == stop_expected
         assert step_result == step_expected