CLN: remove coerce_float keyword from construction.internals

Author: jbrockmendel

pandas/core/frame.py

@@ -1852,7 +1852,11 @@ def from_records(
                 columns = ensure_index(columns)
             arr_columns = columns
         else:
-            arrays, arr_columns = to_arrays(data, columns, coerce_float=coerce_float)
+            arrays, arr_columns = to_arrays(data, columns)
+            if coerce_float:
+                for i, arr in enumerate(arrays):
+                    if arr.dtype == object:
+                        arrays[i] = lib.maybe_convert_objects(arr, try_float=True)
 
             arr_columns = ensure_index(arr_columns)
             if columns is not None:

pandas/core/internals/construction.py

@@ -499,9 +499,7 @@ def dataclasses_to_dicts(data):
 # Conversion of Inputs to Arrays
 
 
-def to_arrays(
-    data, columns, coerce_float: bool = False, dtype: Optional[DtypeObj] = None
-):
+def to_arrays(data, columns, dtype: Optional[DtypeObj] = None):
     """
     Return list of arrays, columns.
     """
@@ -525,15 +523,11 @@ def to_arrays(
                 return [[]] * len(columns), columns
         return [], []  # columns if columns is not None else []
     if isinstance(data[0], (list, tuple)):
-        return _list_to_arrays(data, columns, coerce_float=coerce_float, dtype=dtype)
+        return _list_to_arrays(data, columns, dtype=dtype)
     elif isinstance(data[0], abc.Mapping):
-        return _list_of_dict_to_arrays(
-            data, columns, coerce_float=coerce_float, dtype=dtype
-        )
+        return _list_of_dict_to_arrays(data, columns, dtype=dtype)
     elif isinstance(data[0], ABCSeries):
-        return _list_of_series_to_arrays(
-            data, columns, coerce_float=coerce_float, dtype=dtype
-        )
+        return _list_of_series_to_arrays(data, columns, dtype=dtype)
     elif isinstance(data[0], Categorical):
         if columns is None:
             columns = ibase.default_index(len(data))
@@ -549,13 +543,12 @@ def to_arrays(
     else:
         # last ditch effort
         data = [tuple(x) for x in data]
-        return _list_to_arrays(data, columns, coerce_float=coerce_float, dtype=dtype)
+        return _list_to_arrays(data, columns, dtype=dtype)
 
 
 def _list_to_arrays(
     data: List[Scalar],
     columns: Union[Index, List],
-    coerce_float: bool = False,
     dtype: Optional[DtypeObj] = None,
 ) -> Tuple[List[Scalar], Union[Index, List[Axis]]]:
     if len(data) > 0 and isinstance(data[0], tuple):
@@ -566,7 +559,7 @@ def _list_to_arrays(
     # gh-26429 do not raise user-facing AssertionError
     try:
         columns = _validate_or_indexify_columns(content, columns)
-        result = _convert_object_array(content, dtype=dtype, coerce_float=coerce_float)
+        result = _convert_object_array(content, dtype=dtype)
     except AssertionError as e:
         raise ValueError(e) from e
     return result, columns
@@ -575,7 +568,6 @@ def _list_to_arrays(
 def _list_of_series_to_arrays(
     data: List,
     columns: Union[Index, List],
-    coerce_float: bool = False,
     dtype: Optional[DtypeObj] = None,
 ) -> Tuple[List[Scalar], Union[Index, List[Axis]]]:
     if columns is None:
@@ -604,7 +596,7 @@ def _list_of_series_to_arrays(
     if values.dtype == np.object_:
         content = list(values.T)
         columns = _validate_or_indexify_columns(content, columns)
-        content = _convert_object_array(content, dtype=dtype, coerce_float=coerce_float)
+        content = _convert_object_array(content, dtype=dtype)
         return content, columns
     else:
         return values.T, columns
@@ -613,7 +605,6 @@ def _list_of_series_to_arrays(
 def _list_of_dict_to_arrays(
     data: List[Dict],
     columns: Union[Index, List],
-    coerce_float: bool = False,
     dtype: Optional[DtypeObj] = None,
 ) -> Tuple[List[Scalar], Union[Index, List[Axis]]]:
     """
@@ -629,7 +620,6 @@ def _list_of_dict_to_arrays(
     data : iterable
         collection of records (OrderedDict, dict)
     columns: iterables or None
-    coerce_float : bool
     dtype : np.dtype
 
     Returns
@@ -648,7 +638,7 @@ def _list_of_dict_to_arrays(
 
     content = list(lib.dicts_to_array(data, list(columns)).T)
     columns = _validate_or_indexify_columns(content, columns)
-    content = _convert_object_array(content, dtype=dtype, coerce_float=coerce_float)
+    content = _convert_object_array(content, dtype=dtype)
     return content, columns
 
 
@@ -711,15 +701,14 @@ def _validate_or_indexify_columns(
 
 
 def _convert_object_array(
-    content: List[Scalar], coerce_float: bool = False, dtype: Optional[DtypeObj] = None
+    content: List[Scalar], dtype: Optional[DtypeObj] = None
 ) -> List[Scalar]:
     """
     Internal function ot convert object array.
 
     Parameters
     ----------
     content: list of processed data records
-    coerce_float: bool, to coerce floats or not, default is False
     dtype: np.dtype, default is None
 
     Returns
@@ -729,7 +718,7 @@ def _convert_object_array(
     # provide soft conversion of object dtypes
     def convert(arr):
         if dtype != np.dtype("O"):
-            arr = lib.maybe_convert_objects(arr, try_float=coerce_float)
+            arr = lib.maybe_convert_objects(arr)
             arr = maybe_cast_to_datetime(arr, dtype)
         return arr