Skip to content

Commit deafc21

Browse files
committed
REF: remove useless code (dtype has info about ordering)
1 parent d949213 commit deafc21

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

pandas/core/categorical.py

+2-11
Original file line numberDiff line numberDiff line change
@@ -293,15 +293,6 @@ def __init__(self, values, categories=None, ordered=None, dtype=None,
293293

294294
# sanitize input
295295
if is_categorical_dtype(values):
296-
297-
# we are either a Series or a CategoricalIndex
298-
if isinstance(values, (ABCSeries, ABCCategoricalIndex)):
299-
values = values._values
300-
301-
if ordered is None:
302-
ordered = values.ordered
303-
if categories is None:
304-
categories = values.categories
305296
values = values.get_values()
306297

307298
elif isinstance(values, (ABCIndexClass, ABCSeries)):
@@ -334,7 +325,7 @@ def __init__(self, values, categories=None, ordered=None, dtype=None,
334325
codes, categories = factorize(values, sort=True)
335326
except TypeError:
336327
codes, categories = factorize(values, sort=False)
337-
if ordered:
328+
if dtype.ordered:
338329
# raise, as we don't have a sortable data structure and so
339330
# the user should give us one by specifying categories
340331
raise TypeError("'values' is not ordered, please "
@@ -348,7 +339,7 @@ def __init__(self, values, categories=None, ordered=None, dtype=None,
348339

349340
if dtype.categories is None:
350341
# we're inferring from values
351-
dtype = CategoricalDtype(categories, ordered)
342+
dtype = CategoricalDtype(categories, dtype.ordered)
352343

353344
else:
354345
# there were two ways if categories are present

0 commit comments

Comments
 (0)