Skip to content

Commit de98e24

Browse files
committed
ENH: specify dependency list for tseries Cython module, GH #271
1 parent 32d65dd commit de98e24

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

Makefile

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ clean:
22
-rm -rf build dist
33

44
tseries: pandas/src/tseries.pyx
5-
touch pandas/src/tseries.pyx
65
python setup.py build_ext --inplace
76

87
sparse: pandas/src/sparse.pyx

RELEASE.rst

+1
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ feedback on the library.
149149
the source directory (GH #250)
150150
- Significantly speed up DataFrame `__repr__` and `count` on large mixed-type
151151
DataFrame objects
152+
- Better handling of pyx file dependencies in Cython module build (GH #271)
152153

153154
**Bug fixes**
154155

setup.py

+13-5
Original file line numberDiff line numberDiff line change
@@ -274,22 +274,30 @@ def run(self):
274274
cmdclass['build_ext'] = build_ext
275275
cmdclass['sdist'] = CheckSDist
276276

277-
tseries_depends = ['reindex', 'io', 'common', 'groupby'
278-
'skiplist', 'isnull', 'moments', 'operators']
279-
277+
tseries_depends = ['reindex', 'groupby', 'skiplist', 'moments',
278+
'generated', 'parsing']
280279
def srcpath(name=None, suffix='.pyx', subdir='src'):
281280
return pjoin('pandas', subdir, name+suffix)
282281

282+
if suffix == '.pyx':
283+
tseries_depends = [srcpath(f, suffix='.pyx')
284+
for f in tseries_depends]
285+
else:
286+
tseries_depends = None
287+
288+
print tseries_depends
289+
283290
tseries_ext = Extension('pandas._tseries',
291+
depends=tseries_depends,
284292
sources=[srcpath('tseries', suffix=suffix)],
285-
# depends=[srcpath(f, suffix='.pyx')
286-
# for f in tseries_depends],
287293
include_dirs=[np.get_include()])
294+
288295
sparse_ext = Extension('pandas._sparse',
289296
sources=[srcpath('sparse', suffix=suffix)],
290297
include_dirs=[np.get_include()])
291298
extensions = [tseries_ext,
292299
sparse_ext]
300+
293301
# if _have_setuptools:
294302
# setuptools_args["test_suite"] = "nose.collector"
295303

0 commit comments

Comments
 (0)