Skip to content

Commit de49e43

Browse files
author
Mike Phung
committed
TST GH#40498 Add tests for fillna other missing values not modified.
1 parent 99cf794 commit de49e43

File tree

2 files changed

+35
-0
lines changed

2 files changed

+35
-0
lines changed

pandas/tests/frame/methods/test_fillna.py

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,28 @@ def test_fillna_tzaware_different_column(self):
153153
)
154154
tm.assert_frame_equal(result, expected)
155155

156+
def test_other_missing_values_not_modified(
157+
self, unique_nulls_fixture, unique_nulls_fixture2
158+
):
159+
# GH#40498
160+
df = DataFrame(
161+
{
162+
"A": [1, unique_nulls_fixture, unique_nulls_fixture2, "four"],
163+
"B": [2, unique_nulls_fixture, unique_nulls_fixture2, "eight"],
164+
}
165+
)
166+
value = {"A": {1: 0}, "B": {2: 0}}
167+
result = df.fillna(value)
168+
169+
expected = DataFrame(
170+
{
171+
"A": [1, 0, unique_nulls_fixture2, "four"],
172+
"B": [2, unique_nulls_fixture, 0, "eight"],
173+
}
174+
)
175+
176+
tm.assert_frame_equal(result, expected)
177+
156178
def test_na_actions_categorical(self):
157179

158180
cat = Categorical([1, 2, 3, np.nan], categories=[1, 2, 3])

pandas/tests/series/methods/test_fillna.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,19 @@ def test_fillna_numeric_inplace(self):
623623
expected = x.fillna(value=0)
624624
tm.assert_series_equal(y, expected)
625625

626+
def test_fillna_other_missing_values_not_modified(
627+
self, unique_nulls_fixture, unique_nulls_fixture2
628+
):
629+
# GH#40498
630+
ser = Series([1, unique_nulls_fixture, unique_nulls_fixture2, "four"])
631+
632+
value = {2: 0}
633+
result = ser.fillna(value)
634+
635+
expected = Series([1, unique_nulls_fixture, 0, "four"])
636+
637+
tm.assert_series_equal(result, expected)
638+
626639
# ---------------------------------------------------------------
627640
# CategoricalDtype
628641

0 commit comments

Comments
 (0)