Skip to content

Commit dc4f474

Browse files
committed
Roll validate_minmax_axis into existing validate functions
1 parent b90f421 commit dc4f474

File tree

2 files changed

+32
-16
lines changed

2 files changed

+32
-16
lines changed

pandas/compat/numpy/function.py

+28-8
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,30 @@ def __call__(self, args, kwargs, fname=None,
5858

5959

6060
ARGMINMAX_DEFAULTS = dict(out=None)
61-
validate_argmin = CompatValidator(ARGMINMAX_DEFAULTS, fname='argmin',
62-
method='both', max_fname_arg_count=1)
63-
validate_argmax = CompatValidator(ARGMINMAX_DEFAULTS, fname='argmax',
64-
method='both', max_fname_arg_count=1)
61+
_validate_argmin = CompatValidator(ARGMINMAX_DEFAULTS, fname='argmin',
62+
method='both', max_fname_arg_count=1)
63+
_validate_argmax = CompatValidator(ARGMINMAX_DEFAULTS, fname='argmax',
64+
method='both', max_fname_arg_count=1)
65+
66+
67+
def validate_argmin(args, kwargs, axis=None):
68+
_validate_argmin(args, kwargs)
69+
validate_minmax_axis(axis)
70+
71+
72+
def validate_argmax(args, kwargs, axis=None):
73+
_validate_argmax(args, kwargs)
74+
validate_minmax_axis(axis)
75+
76+
77+
def validate_min(args, kwargs, axis=None):
78+
_validate_min(args, kwargs)
79+
validate_minmax_axis(axis)
80+
81+
82+
def validate_max(args, kwargs, axis=None):
83+
_validate_max(args, kwargs)
84+
validate_minmax_axis(axis)
6585

6686

6787
def process_skipna(skipna, args):
@@ -196,10 +216,10 @@ def validate_cum_func_with_skipna(skipna, args, kwargs, name):
196216
validate_logical_func = CompatValidator(LOGICAL_FUNC_DEFAULTS, method='kwargs')
197217

198218
MINMAX_DEFAULTS = dict(out=None)
199-
validate_min = CompatValidator(MINMAX_DEFAULTS, fname='min',
200-
method='both', max_fname_arg_count=1)
201-
validate_max = CompatValidator(MINMAX_DEFAULTS, fname='max',
202-
method='both', max_fname_arg_count=1)
219+
_validate_min = CompatValidator(MINMAX_DEFAULTS, fname='min',
220+
method='both', max_fname_arg_count=1)
221+
_validate_max = CompatValidator(MINMAX_DEFAULTS, fname='max',
222+
method='both', max_fname_arg_count=1)
203223

204224
RESHAPE_DEFAULTS = dict(order='C')
205225
validate_reshape = CompatValidator(RESHAPE_DEFAULTS, fname='reshape',

pandas/core/indexes/datetimelike.py

+4-8
Original file line numberDiff line numberDiff line change
@@ -430,8 +430,7 @@ def min(self, axis=None, *args, **kwargs):
430430
--------
431431
numpy.ndarray.min
432432
"""
433-
nv.validate_minmax_axis(axis)
434-
nv.validate_min(args, kwargs)
433+
nv.validate_min(args, kwargs, axis=axis)
435434

436435
try:
437436
i8 = self.asi8
@@ -459,8 +458,7 @@ def argmin(self, axis=None, *args, **kwargs):
459458
--------
460459
numpy.ndarray.argmin
461460
"""
462-
nv.validate_minmax_axis(axis)
463-
nv.validate_argmin(args, kwargs)
461+
nv.validate_argmin(args, kwargs, axis=axis)
464462

465463
i8 = self.asi8
466464
if self.hasnans:
@@ -480,8 +478,7 @@ def max(self, axis=None, *args, **kwargs):
480478
--------
481479
numpy.ndarray.max
482480
"""
483-
nv.validate_minmax_axis(axis)
484-
nv.validate_max(args, kwargs)
481+
nv.validate_max(args, kwargs, axis=axis)
485482

486483
try:
487484
i8 = self.asi8
@@ -509,8 +506,7 @@ def argmax(self, axis=None, *args, **kwargs):
509506
--------
510507
numpy.ndarray.argmax
511508
"""
512-
nv.validate_minmax_axis(axis)
513-
nv.validate_argmax(args, kwargs)
509+
nv.validate_argmax(args, kwargs, axis=axis)
514510

515511
i8 = self.asi8
516512
if self.hasnans:

0 commit comments

Comments
 (0)