TYP: Adjust typing for Blockplacement.__getitem__ (#51036)

* TYP: Adjust typing for Blockplacement.__getitem__

* Fix typing

* Fix typing

Author: phofl

pandas/_libs/internals.pyi

@@ -44,7 +44,9 @@ class BlockPlacement:
     @property
     def is_slice_like(self) -> bool: ...
     @overload
-    def __getitem__(self, loc: slice | Sequence[int]) -> BlockPlacement: ...
+    def __getitem__(
+        self, loc: slice | Sequence[int] | npt.NDArray[np.intp]
+    ) -> BlockPlacement: ...
     @overload
     def __getitem__(self, loc: int) -> int: ...
     def __iter__(self) -> Iterator[int]: ...

pandas/core/internals/blocks.py

@@ -258,9 +258,7 @@ def getitem_block(self, slicer: slice | npt.NDArray[np.intp]) -> Block:
         #  is from internals.concat, and we can verify that never happens
         #  with 1-column blocks, i.e. never for ExtensionBlock.
 
-        # Invalid index type "Union[slice, ndarray[Any, dtype[signedinteger[Any]]]]"
-        # for "BlockPlacement"; expected type "Union[slice, Sequence[int]]"
-        new_mgr_locs = self._mgr_locs[slicer]  # type: ignore[index]
+        new_mgr_locs = self._mgr_locs[slicer]
 
         new_values = self._slice(slicer)
 

pandas/core/internals/managers.py

@@ -1320,11 +1320,11 @@ def _iset_split_block(
 
         nbs_tup = tuple(blk.delete(blk_locs))
         if value is not None:
-            # error: No overload variant of "__getitem__" of "BlockPlacement" matches
-            # argument type "ndarray[Any, Any]"  [call-overload]
+            # Argument 1 to "BlockPlacement" has incompatible type "BlockPlacement";
+            # expected "Union[int, slice, ndarray[Any, Any]]"
             first_nb = new_block_2d(
                 value,
-                BlockPlacement(blk.mgr_locs[blk_locs]),  # type: ignore[call-overload]
+                BlockPlacement(blk.mgr_locs[blk_locs]),  # type: ignore[arg-type]
             )
         else:
             first_nb = nbs_tup[0]