Skip to content

Commit dae4aba

Browse files
committed
Flake8 windows suggestion
1 parent d53a981 commit dae4aba

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
- [ ] closes #xxxx
22
- [ ] tests added / passed
3-
- [ ] passes ``git diff upstream/master --name-only -- '*.py' | flake8 --diff``
3+
- [ ] passes ``git diff upstream/master --name-only -- '*.py' | flake8 --diff`` (On Windows, ``git diff upstream/master -u -- "*.py" | flake8 --diff`` might work as an alternative.)
44
- [ ] whatsnew entry

doc/source/contributing.rst

+5
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,11 @@ run this slightly modified command::
525525

526526
git diff master --name-only -- '*.py' | grep 'pandas/' | xargs flake8
527527

528+
Note that on Windows, `grep`, `xargs`, and other tools are likely unavailable.
529+
However, this has been shown to work on smaller commits::
530+
531+
git diff master -u -- "*.py" | flake8 --diff
532+
528533
Backwards Compatibility
529534
~~~~~~~~~~~~~~~~~~~~~~~
530535

0 commit comments

Comments
 (0)