Incorporate review (jreback)

Author: h-vetinari

pandas/conftest.py

@@ -334,6 +334,38 @@ def any_int_dtype(request):
     return request.param
 
 
+FLOAT_DTYPES = [float, "float32", "float64"]
+COMPLEX_DTYPES = [complex, "complex64", "complex128"]
+STRING_DTYPES = [str, 'str', 'U']
+ALL_NUMPY_DTYPES = (ALL_INT_DTYPES + FLOAT_DTYPES
+                    + STRING_DTYPES + COMPLEX_DTYPES)
+
+
+@pytest.fixture(params=ALL_NUMPY_DTYPES)
+def any_numpy_dtype(request):
+    """
+    Parameterized fixture for any integer dtypes.
+
+    * int8
+    * uint8
+    * int16
+    * uint16
+    * int32
+    * uint32
+    * int64
+    * uint64
+    * str
+    * 'str'
+    * 'U'
+    * float32
+    * float64
+    * complex64
+    * complex128
+    """
+
+    return request.param
+
+
 @pytest.fixture
 def mock():
     """

pandas/tests/series/test_analytics.py

@@ -962,9 +962,8 @@ def test_unique(self):
             ('last', Series([False, True, True, False, False, False, False])),
             (False, Series([False, True, True, False, True, True, False]))
         ])
-    @pytest.mark.parametrize('npdtype', ['int_', 'uint', 'float_', 'unicode_'])
-    def test_drop_duplicates_non_bool(self, npdtype, keep, expected):
-        tc = Series([1, 2, 3, 5, 3, 2, 4], dtype=np.dtype(npdtype))
+    def test_drop_duplicates_non_bool(self, any_numpy_dtype, keep, expected):
+        tc = Series([1, 2, 3, 5, 3, 2, 4], dtype=np.dtype(any_numpy_dtype))
 
         assert_series_equal(tc.duplicated(keep=keep), expected)
         assert_series_equal(tc.drop_duplicates(keep=keep), tc[~expected])