ERR: Raise a better error message with to_pydatetime and ArrowDtype(pa.date) (#52952)

* ERR: Raise a better error message with to_pydatetime and ArrowDtype(pa.date)

* Update pandas/tests/extension/test_arrow.py

* Add warning

* fix error message

* Suggest to convert to pyarrow timestamp type first

Author: mroeschke

Diff for: doc/source/whatsnew/v2.0.2.rst

@@ -31,7 +31,7 @@ Bug fixes
 
 Other
 ~~~~~
--
+- Raised a better error message when calling :func:`Series.dt.to_pydatetime` with :class:`ArrowDtype` with ``pyarrow.date32`` or ``pyarrow.date64`` type (:issue:`52812`)
 
 .. ---------------------------------------------------------------------------
 .. _whatsnew_202.contributors:

Diff for: pandas/core/arrays/arrow/array.py

@@ -2344,6 +2344,11 @@ def _dt_month_name(self, locale: str | None = None):
         return type(self)(pc.strftime(self._pa_array, format="%B", locale=locale))
 
     def _dt_to_pydatetime(self):
+        if pa.types.is_date(self.dtype.pyarrow_dtype):
+            raise ValueError(
+                f"to_pydatetime cannot be called with {self.dtype.pyarrow_dtype} type. "
+                "Convert to pyarrow timestamp type."
+            )
         data = self._pa_array.to_pylist()
         if self._dtype.pyarrow_dtype.unit == "ns":
             data = [None if ts is None else ts.to_pydatetime(warn=False) for ts in data]

Diff for: pandas/tests/extension/test_arrow.py

@@ -2615,6 +2615,19 @@ def test_dt_to_pydatetime():
     tm.assert_numpy_array_equal(result, expected)
 
 
+@pytest.mark.parametrize("date_type", [32, 64])
+def test_dt_to_pydatetime_date_error(date_type):
+    # GH 52812
+    ser = pd.Series(
+        [date(2022, 12, 31)],
+        dtype=ArrowDtype(getattr(pa, f"date{date_type}")()),
+    )
+    msg = "The behavior of ArrowTemporalProperties.to_pydatetime is deprecated"
+    with tm.assert_produces_warning(FutureWarning, match=msg):
+        with pytest.raises(ValueError, match="to_pydatetime cannot be called with"):
+            ser.dt.to_pydatetime()
+
+
 def test_dt_tz_localize_unsupported_tz_options():
     ser = pd.Series(
         [datetime(year=2023, month=1, day=2, hour=3), None],