Skip to content

Commit d5c757d

Browse files
committed
unskip sqlalchemy sqlite tests
1 parent 7661885 commit d5c757d

File tree

1 file changed

+33
-42
lines changed

1 file changed

+33
-42
lines changed

pandas/tests/io/test_sql.py

Lines changed: 33 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -764,80 +764,71 @@ def postgresql_psycopg2_conn_types(postgresql_psycopg2_engine_types):
764764

765765
@pytest.fixture
766766
def sqlite_str():
767-
pytest.skip("Skipping MySQL tests")
768-
# pytest.importorskip("sqlalchemy")
769-
# with tm.ensure_clean() as name:
770-
# yield f"sqlite:///{name}"
767+
pytest.importorskip("sqlalchemy")
768+
with tm.ensure_clean() as name:
769+
yield f"sqlite:///{name}"
771770

772771

773772
@pytest.fixture
774773
def sqlite_engine(sqlite_str):
775-
pytest.skip("Skipping MySQL tests")
776-
# sqlalchemy = pytest.importorskip("sqlalchemy")
777-
# engine = sqlalchemy.create_engine(sqlite_str, poolclass=sqlalchemy.pool.NullPool)
778-
# yield engine
779-
# for view in get_all_views(engine):
780-
# drop_view(view, engine)
781-
# for tbl in get_all_tables(engine):
782-
# drop_table(tbl, engine)
783-
# engine.dispose()
774+
sqlalchemy = pytest.importorskip("sqlalchemy")
775+
engine = sqlalchemy.create_engine(sqlite_str, poolclass=sqlalchemy.pool.NullPool)
776+
yield engine
777+
for view in get_all_views(engine):
778+
drop_view(view, engine)
779+
for tbl in get_all_tables(engine):
780+
drop_table(tbl, engine)
781+
engine.dispose()
784782

785783

786784
@pytest.fixture
787785
def sqlite_conn(sqlite_engine):
788-
pytest.skip("Skipping MySQL tests")
789-
# with sqlite_engine.connect() as conn:
790-
# yield conn
786+
with sqlite_engine.connect() as conn:
787+
yield conn
791788

792789

793790
@pytest.fixture
794791
def sqlite_str_iris(sqlite_str, iris_path):
795-
pytest.skip("Skipping MySQL tests")
796-
# sqlalchemy = pytest.importorskip("sqlalchemy")
797-
# engine = sqlalchemy.create_engine(sqlite_str)
798-
# create_and_load_iris(engine, iris_path)
799-
# create_and_load_iris_view(engine)
800-
# engine.dispose()
801-
# return sqlite_str
792+
sqlalchemy = pytest.importorskip("sqlalchemy")
793+
engine = sqlalchemy.create_engine(sqlite_str)
794+
create_and_load_iris(engine, iris_path)
795+
create_and_load_iris_view(engine)
796+
engine.dispose()
797+
return sqlite_str
802798

803799

804800
@pytest.fixture
805801
def sqlite_engine_iris(sqlite_engine, iris_path):
806-
pytest.skip("Skipping MySQL tests")
807-
# create_and_load_iris(sqlite_engine, iris_path)
808-
# create_and_load_iris_view(sqlite_engine)
809-
# return sqlite_engine
802+
create_and_load_iris(sqlite_engine, iris_path)
803+
create_and_load_iris_view(sqlite_engine)
804+
return sqlite_engine
810805

811806

812807
@pytest.fixture
813808
def sqlite_conn_iris(sqlite_engine_iris):
814-
pytest.skip("Skipping MySQL tests")
815-
# with sqlite_engine_iris.connect() as conn:
816-
# yield conn
809+
with sqlite_engine_iris.connect() as conn:
810+
yield conn
817811

818812

819813
@pytest.fixture
820814
def sqlite_str_types(sqlite_str, types_data):
821-
pytest.skip("Skipping MySQL tests")
822-
# sqlalchemy = pytest.importorskip("sqlalchemy")
823-
# engine = sqlalchemy.create_engine(sqlite_str)
824-
# create_and_load_types(engine, types_data, "sqlite")
825-
# engine.dispose()
826-
# return sqlite_str
815+
sqlalchemy = pytest.importorskip("sqlalchemy")
816+
engine = sqlalchemy.create_engine(sqlite_str)
817+
create_and_load_types(engine, types_data, "sqlite")
818+
engine.dispose()
819+
return sqlite_str
827820

828821

829822
@pytest.fixture
830823
def sqlite_engine_types(sqlite_engine, types_data):
831-
pytest.skip("Skipping MySQL tests")
832-
# create_and_load_types(sqlite_engine, types_data, "sqlite")
833-
# return sqlite_engine
824+
create_and_load_types(sqlite_engine, types_data, "sqlite")
825+
return sqlite_engine
834826

835827

836828
@pytest.fixture
837829
def sqlite_conn_types(sqlite_engine_types):
838-
pytest.skip("Skipping MySQL tests")
839-
# with sqlite_engine_types.connect() as conn:
840-
# yield conn
830+
with sqlite_engine_types.connect() as conn:
831+
yield conn
841832

842833

843834
@pytest.fixture

0 commit comments

Comments
 (0)