Skip to content

Commit d481c92

Browse files
add more tests
1 parent 577b329 commit d481c92

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

pandas/tests/extension/base/setitem.py

+14
Original file line numberDiff line numberDiff line change
@@ -357,6 +357,20 @@ def test_setitem_with_expansion_dataframe_column(self, data, full_indexer):
357357

358358
self.assert_frame_equal(result, expected)
359359

360+
def test_setitem_with_expansion_row(self, data, na_value):
361+
df = pd.DataFrame({"data": data[:1]})
362+
363+
df.loc[1, "data"] = data[1]
364+
expected = pd.DataFrame({"data": data[:2]})
365+
self.assert_frame_equal(df, expected)
366+
367+
# https://github.com/pandas-dev/pandas/issues/47284
368+
df.loc[2, "data"] = na_value
369+
expected = pd.DataFrame(
370+
{"data": pd.Series([data[0], data[1], na_value], dtype=data.dtype)}
371+
)
372+
self.assert_frame_equal(df, expected)
373+
360374
def test_setitem_series(self, data, full_indexer):
361375
# https://github.com/pandas-dev/pandas/issues/32395
362376
ser = pd.Series(data, name="data")

pandas/tests/reshape/concat/test_concat.py

+9
Original file line numberDiff line numberDiff line change
@@ -792,3 +792,12 @@ def test_concat_ignore_all_na_object_float(empty_dtype, df_dtype):
792792
df_dtype = "float64"
793793
expected = DataFrame({"foo": [None, 1, 2], "bar": [None, 1, 2]}, dtype=df_dtype)
794794
tm.assert_frame_equal(result, expected)
795+
796+
797+
def test_concat_ignore_empty_from_reindex():
798+
# https://github.com/pandas-dev/pandas/pull/43507#issuecomment-920375856
799+
df1 = DataFrame({"a": [1], "b": [pd.Timestamp("2012-01-01")]})
800+
df2 = DataFrame({"a": [2]})
801+
802+
result = concat([df1, df2.reindex(columns=df1.columns)])
803+
tm.assert_frame_equal(result, df1)

0 commit comments

Comments
 (0)