Skip to content

Commit d2a14ac

Browse files
fixed mypy errors in pandas.tests.extension.json.test_json (#31836)
1 parent a96bdbd commit d2a14ac

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

pandas/tests/extension/json/test_json.py

+6-4
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ class BaseJSON:
7979
# The default assert_series_equal eventually does a
8080
# Series.values, which raises. We work around it by
8181
# converting the UserDicts to dicts.
82-
def assert_series_equal(self, left, right, **kwargs):
82+
@classmethod
83+
def assert_series_equal(cls, left, right, *args, **kwargs):
8384
if left.dtype.name == "json":
8485
assert left.dtype == right.dtype
8586
left = pd.Series(
@@ -90,9 +91,10 @@ def assert_series_equal(self, left, right, **kwargs):
9091
index=right.index,
9192
name=right.name,
9293
)
93-
tm.assert_series_equal(left, right, **kwargs)
94+
tm.assert_series_equal(left, right, *args, **kwargs)
9495

95-
def assert_frame_equal(self, left, right, *args, **kwargs):
96+
@classmethod
97+
def assert_frame_equal(cls, left, right, *args, **kwargs):
9698
obj_type = kwargs.get("obj", "DataFrame")
9799
tm.assert_index_equal(
98100
left.columns,
@@ -107,7 +109,7 @@ def assert_frame_equal(self, left, right, *args, **kwargs):
107109
jsons = (left.dtypes == "json").index
108110

109111
for col in jsons:
110-
self.assert_series_equal(left[col], right[col], *args, **kwargs)
112+
cls.assert_series_equal(left[col], right[col], *args, **kwargs)
111113

112114
left = left.drop(columns=jsons)
113115
right = right.drop(columns=jsons)

setup.cfg

-3
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,6 @@ ignore_errors=True
135135
[mypy-pandas.tests.arithmetic.test_datetime64]
136136
ignore_errors=True
137137

138-
[mypy-pandas.tests.extension.json.test_json]
139-
ignore_errors=True
140-
141138
[mypy-pandas.tests.indexes.datetimes.test_tools]
142139
ignore_errors=True
143140

0 commit comments

Comments
 (0)