Skip to content

Commit d22b382

Browse files
Merge pull request #8474 from jorisvandenbossche/sql-8314-time
TEST: add for sqlite fallback raising on datetime.time (and not failing silently) GH8341
2 parents 54621c7 + 93fd023 commit d22b382

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

pandas/io/tests/test_sql.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -1398,8 +1398,12 @@ def test_datetime_date(self):
13981398

13991399
def test_datetime_time(self):
14001400
# test support for datetime.time
1401-
raise nose.SkipTest("datetime.time not supported for sqlite fallback")
1402-
1401+
df = DataFrame([time(9, 0, 0), time(9, 1, 30)], columns=["a"])
1402+
# test it raises an error and not fails silently (GH8341)
1403+
if self.flavor == 'sqlite':
1404+
self.assertRaises(sqlite3.InterfaceError, sql.to_sql, df,
1405+
'test_time', self.conn)
1406+
14031407
def _get_index_columns(self, tbl_name):
14041408
ixs = sql.read_sql_query(
14051409
"SELECT * FROM sqlite_master WHERE type = 'index' " +

0 commit comments

Comments
 (0)