Skip to content

Commit d207a25

Browse files
committed
BUG: always return True for onOffset for regular DateOffset, close #770
1 parent 1be6d08 commit d207a25

File tree

4 files changed

+19
-3
lines changed

4 files changed

+19
-3
lines changed

RELEASE.rst

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ Where to get it
2020

2121
* Source code: http://github.com/pydata/pandas
2222
* Binary installers on PyPI: http://pypi.python.org/pypi/pandas
23-
* Documentation: http://pandas.sourceforge.net
23+
* Documentation: http://pandas.pydata.org
2424

2525
pandas 0.7.0
2626
============
2727

28-
**Release date:** NOT YET RELEASED
28+
**Release date:** 2/9/2012
2929

3030
**New features / modules**
3131

@@ -187,6 +187,9 @@ pandas 0.7.0
187187
- Prototypes for some vectorized string functions
188188
- Add float64 hash table to solve the Series.unique problem with NAs (GH #714)
189189
- Memoize objects when reading from file to reduce memory footprint
190+
- Can get and set a column of a DataFrame with hierarchical columns
191+
containing "empty" ('') lower levels without passing the empty levels (PR
192+
#768)
190193

191194
**Bug fixes**
192195

@@ -301,6 +304,7 @@ pandas 0.7.0
301304
Thanks
302305
------
303306
- Craig Austin
307+
- Chris Billington
304308
- Marius Cobzarenco
305309
- Mario Gamboa-Cavazos
306310
- Hans-Martin Gaudecker

doc/source/whatsnew/v0.7.0.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
.. _whatsnew_0700:
22

3-
v.0.7.0 (Not Yet Released)
3+
v.0.7.0 (February 9, 2012)
44
--------------------------
55

66
New features

pandas/core/datetools.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,9 @@ def rollforward(self, someDate):
218218
return someDate
219219

220220
def onOffset(self, someDate):
221+
if type(self) == DateOffset:
222+
return True
223+
221224
# Default (slow) method for determining if some date is a
222225
# member of the DateRange generated by this offset. Subclasses
223226
# may have this re-implemented in a nicer way.

pandas/tests/test_daterange.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,15 @@ def test_error_with_zero_monthends(self):
354354
self.assertRaises(ValueError, DateRange, '1/1/2000', '1/1/2001',
355355
offset=datetools.MonthEnd(0))
356356

357+
def test_range_bug(self):
358+
# GH #770
359+
offset = datetools.DateOffset(months=3)
360+
result = DateRange("2011-1-1", "2012-1-31", offset=offset)
361+
362+
start = datetime(2011, 1, 1)
363+
exp_values = [start + i * offset for i in range(5)]
364+
self.assert_(np.array_equal(result, exp_values))
365+
357366
def _skip_if_no_pytz():
358367
try:
359368
import pytz

0 commit comments

Comments
 (0)