Skip to content

Commit d16dc5a

Browse files
WillAydjreback
authored andcommitted
Pull Request Tips (#31093)
1 parent 6245c70 commit d16dc5a

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

doc/source/development/contributing.rst

+16
Original file line numberDiff line numberDiff line change
@@ -1525,3 +1525,19 @@ The branch will still exist on GitHub, so to delete it there do::
15251525
git push origin --delete shiny-new-feature
15261526

15271527
.. _Gitter: https://gitter.im/pydata/pandas
1528+
1529+
1530+
Tips for a successful Pull Request
1531+
==================================
1532+
1533+
If you have made it to the `Review your code`_ phase, one of the core contributors may
1534+
take a look. Please note however that a handful of people are responsible for reviewing
1535+
all of the contributions, which can often lead to bottlenecks.
1536+
1537+
To improve the chances of your pull request being reviewed, you should:
1538+
1539+
- **Reference an open issue** for non-trivial changes to clarify the PR's purpose
1540+
- **Ensure you have appropriate tests**. These should be the first part of any PR
1541+
- **Keep your pull requests as simple as possible**. Larger PRs take longer to review
1542+
- **Ensure that CI is in a green state**. Reviewers may not even look otherwise
1543+
- **Keep** `Updating your pull request`_, either by request or every few days

0 commit comments

Comments
 (0)