Skip to content

Commit d08ca2f

Browse files
authored
add comment (#37876)
1 parent f34fe62 commit d08ca2f

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

pandas/_libs/src/klib/khash_python.h

+5
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@
1616
// GH 13436 showed that _Py_HashDouble doesn't work well with khash
1717
// GH 28303 showed, that the simple xoring-version isn't good enough
1818
// See GH 36729 for evaluation of the currently used murmur2-hash version
19+
// An interesting alternative to expensive murmur2-hash would be to change
20+
// the probing strategy and use e.g. the probing strategy from CPython's
21+
// implementation of dicts, which shines for smaller sizes but is more
22+
// predisposed to superlinear running times (see GH 36729 for comparison)
23+
1924

2025
khint64_t PANDAS_INLINE asint64(double key) {
2126
khint64_t val;

0 commit comments

Comments
 (0)