Skip to content

Commit cb43fa6

Browse files
h-vetinarijreback
authored andcommitted
Fixturize tests/frame/test_combine_concat.py (#25634)
1 parent a247f80 commit cb43fa6

File tree

1 file changed

+16
-17
lines changed

1 file changed

+16
-17
lines changed

pandas/tests/frame/test_combine_concat.py

+16-17
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,11 @@
1111

1212
import pandas as pd
1313
from pandas import DataFrame, Index, Series, Timestamp, date_range
14-
from pandas.tests.frame.common import TestData
1514
import pandas.util.testing as tm
1615
from pandas.util.testing import assert_frame_equal, assert_series_equal
1716

1817

19-
class TestDataFrameConcatCommon(TestData):
18+
class TestDataFrameConcatCommon():
2019

2120
def test_concat_multiple_frames_dtypes(self):
2221

@@ -515,7 +514,7 @@ def test_concat_astype_dup_col(self):
515514
tm.assert_frame_equal(result, expected)
516515

517516

518-
class TestDataFrameCombineFirst(TestData):
517+
class TestDataFrameCombineFirst():
519518

520519
def test_combine_first_mixed(self):
521520
a = Series(['a', 'b'], index=lrange(2))
@@ -531,22 +530,22 @@ def test_combine_first_mixed(self):
531530
combined = f.combine_first(g)
532531
tm.assert_frame_equal(combined, exp)
533532

534-
def test_combine_first(self):
533+
def test_combine_first(self, float_frame):
535534
# disjoint
536-
head, tail = self.frame[:5], self.frame[5:]
535+
head, tail = float_frame[:5], float_frame[5:]
537536

538537
combined = head.combine_first(tail)
539-
reordered_frame = self.frame.reindex(combined.index)
538+
reordered_frame = float_frame.reindex(combined.index)
540539
assert_frame_equal(combined, reordered_frame)
541-
assert tm.equalContents(combined.columns, self.frame.columns)
540+
assert tm.equalContents(combined.columns, float_frame.columns)
542541
assert_series_equal(combined['A'], reordered_frame['A'])
543542

544543
# same index
545-
fcopy = self.frame.copy()
544+
fcopy = float_frame.copy()
546545
fcopy['A'] = 1
547546
del fcopy['C']
548547

549-
fcopy2 = self.frame.copy()
548+
fcopy2 = float_frame.copy()
550549
fcopy2['B'] = 0
551550
del fcopy2['D']
552551

@@ -570,20 +569,20 @@ def test_combine_first(self):
570569
assert (combined['A'][:10] == 0).all()
571570

572571
# no overlap
573-
f = self.frame[:10]
574-
g = self.frame[10:]
572+
f = float_frame[:10]
573+
g = float_frame[10:]
575574
combined = f.combine_first(g)
576575
assert_series_equal(combined['A'].reindex(f.index), f['A'])
577576
assert_series_equal(combined['A'].reindex(g.index), g['A'])
578577

579578
# corner cases
580-
comb = self.frame.combine_first(self.empty)
581-
assert_frame_equal(comb, self.frame)
579+
comb = float_frame.combine_first(DataFrame({}))
580+
assert_frame_equal(comb, float_frame)
582581

583-
comb = self.empty.combine_first(self.frame)
584-
assert_frame_equal(comb, self.frame)
582+
comb = DataFrame({}).combine_first(float_frame)
583+
assert_frame_equal(comb, float_frame)
585584

586-
comb = self.frame.combine_first(DataFrame(index=["faz", "boo"]))
585+
comb = float_frame.combine_first(DataFrame(index=["faz", "boo"]))
587586
assert "faz" in comb.index
588587

589588
# #2525
@@ -850,7 +849,7 @@ def test_concat_datetime_datetime64_frame(self):
850849
pd.concat([df1, df2_obj])
851850

852851

853-
class TestDataFrameUpdate(TestData):
852+
class TestDataFrameUpdate():
854853

855854
def test_update_nan(self):
856855
# #15593 #15617

0 commit comments

Comments
 (0)