Skip to content

Commit c6353c4

Browse files
authored
DOCS: clarify self-merging and needs-triage (#54286)
clarify self-merging and needs-triage
1 parent 6f419a8 commit c6353c4

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

doc/source/development/maintaining.rst

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ Here's a typical workflow for triaging a newly opened issue.
121121
unless it's know that this issue should be addressed in a specific release (say
122122
because it's a large regression).
123123

124+
Once you have completed the above, make sure to remove the "needs triage" label.
125+
124126
.. _maintaining.regressions:
125127

126128
Investigating regressions
@@ -296,8 +298,11 @@ Merging pull requests
296298

297299
Only core team members can merge pull requests. We have a few guidelines.
298300

299-
1. You should typically not self-merge your own pull requests. Exceptions include
300-
things like small changes to fix CI (e.g. pinning a package version).
301+
1. You should typically not self-merge your own pull requests without approval.
302+
Exceptions include things like small changes to fix CI
303+
(e.g. pinning a package version). Self-merging with approval from other
304+
core team members is fine if the change is something you're very confident
305+
about.
301306
2. You should not merge pull requests that have an active discussion, or pull
302307
requests that has any ``-1`` votes from a core maintainer. pandas operates
303308
by consensus.

0 commit comments

Comments
 (0)