move plotting to privacy in docs

Author: jreback

doc/source/whatsnew/v0.20.0.txt

@@ -21,7 +21,7 @@ Highlights include:
 - Support for S3 handling now uses ``s3fs``, see :ref:`here <whatsnew_0200.api_breaking.s3>`
 - Google BigQuery support now uses the ``pandas-gbq`` library, see :ref:`here <whatsnew_0200.api_breaking.gbq>`
 - Switched the test framework to use `pytest <http://doc.pytest.org/en/latest>`__ (:issue:`13097`)
-- The ``pandas.tools.plotting`` module has been deprecated, moved to ``pandas.plotting``. See :ref:`here <whatsnew_0200.api_breaking.plotting>`
+- The ``pandas.tools.plotting`` module has been deprecated, moved to ``pandas.plotting``. See :ref:`here <whatsnew_0200.privacy.plotting>`
 
 
 Check the :ref:`API Changes <whatsnew_0200.api_breaking>` and :ref:`deprecations <whatsnew_0200.deprecations>` before updating.
@@ -558,31 +558,6 @@ Using ``.iloc``. Here we will get the location of the 'A' column, then use *posi
   df.iloc[[0, 2], df.columns.get_loc('A')]
 
 
-.. _whatsnew_0200.api_breaking.deprecate_plotting
-
-Deprecate .plotting
-^^^^^^^^^^^^^^^^^^^
-
-The ``pandas.tools.plotting`` module has been deprecated,  in favor of the top level ``pandas.plotting`` module. All the public plotting functions are now available
-from ``pandas.plotting`` (:issue:`12548`).
-
-Furthermore, the top-level ``pandas.scatter_matrix`` and ``pandas.plot_params`` are deprecated.
-Users can import these from ``pandas.plotting`` as well.
-
-Previous script:
-
-.. code-block:: python
-
-   pd.tools.plotting.scatter_matrix(df)
-   pd.scatter_matrix(df)
-
-Should be changed to:
-
-.. code-block:: python
-
-    pd.plotting.scatter_matrix(df)
-
-
 .. _whatsnew_0200.api_breaking.deprecate_panel:
 
 Deprecate Panel
@@ -1365,6 +1340,31 @@ If indicated, a deprecation warning will be issued if you reference that module.
 
 - The function :func:`~pandas.api.type.union_categoricals` is now importable from ``pandas.api.types``, formerly from ``pandas.types.concat`` (:issue:`15998`)
 
+.. _whatsnew_0200.privacy.deprecate_plotting
+
+Deprecate .plotting
+^^^^^^^^^^^^^^^^^^^
+
+The ``pandas.tools.plotting`` module has been deprecated,  in favor of the top level ``pandas.plotting`` module. All the public plotting functions are now available
+from ``pandas.plotting`` (:issue:`12548`).
+
+Furthermore, the top-level ``pandas.scatter_matrix`` and ``pandas.plot_params`` are deprecated.
+Users can import these from ``pandas.plotting`` as well.
+
+Previous script:
+
+.. code-block:: python
+
+   pd.tools.plotting.scatter_matrix(df)
+   pd.scatter_matrix(df)
+
+Should be changed to:
+
+.. code-block:: python
+
+    pd.plotting.scatter_matrix(df)
+
+
 .. _whatsnew_0200.privacy.development:
 
 Other Developement Changes

pandas/plotting/_converter.py

@@ -11,12 +11,12 @@
 from matplotlib.transforms import nonsingular
 
 
-from pandas.types.common import (is_float, is_integer,
-                                 is_integer_dtype,
-                                 is_float_dtype,
-                                 is_datetime64_ns_dtype,
-                                 is_period_arraylike,
-                                 )
+from pandas.core.dtypes.common import (
+    is_float, is_integer,
+    is_integer_dtype,
+    is_float_dtype,
+    is_datetime64_ns_dtype,
+    is_period_arraylike)
 
 from pandas.compat import lrange
 import pandas.compat as compat

pandas/plotting/_core.py

@@ -11,11 +11,12 @@
 
 from pandas.util.decorators import cache_readonly
 from pandas.core.base import PandasObject
-from pandas.types.common import (is_list_like,
-                                 is_integer,
-                                 is_number,
-                                 is_hashable,
-                                 is_iterator)
+from pandas.core.dtypes.common import (
+    is_list_like,
+    is_integer,
+    is_number,
+    is_hashable,
+    is_iterator)
 from pandas.core.common import AbstractMethodError, isnull, _try_sort
 from pandas.core.generic import _shared_docs, _shared_doc_kwargs
 from pandas.core.index import Index, MultiIndex

pandas/plotting/_misc.py

@@ -5,7 +5,7 @@
 import numpy as np
 
 from pandas.util.decorators import deprecate_kwarg
-from pandas.types.missing import notnull
+from pandas.core.dtypes.missing import notnull
 from pandas.compat import range, lrange, lmap, zip
 from pandas.formats.printing import pprint_thing
 

pandas/plotting/_style.py

@@ -8,7 +8,7 @@
 
 import numpy as np
 
-from pandas.types.common import is_list_like
+from pandas.core.dtypes.common import is_list_like
 from pandas.compat import range, lrange, lmap
 import pandas.compat as compat
 from pandas.plotting._compat import _mpl_ge_2_0_0

pandas/plotting/_tools.py

@@ -7,7 +7,7 @@
 
 import numpy as np
 
-from pandas.types.common import is_list_like
+from pandas.core.dtypes.common import is_list_like
 from pandas.core.index import Index
 from pandas.core.series import Series
 from pandas.compat import range