Skip to content

Commit c2a8dc3

Browse files
Albert Villanova del Moraljreback
Albert Villanova del Moral
authored andcommitted
Implement tests
1 parent c12bb3f commit c2a8dc3

File tree

2 files changed

+17
-20
lines changed

2 files changed

+17
-20
lines changed

pandas/tests/frame/test_misc_api.py

+8-13
Original file line numberDiff line numberDiff line change
@@ -61,37 +61,32 @@ def test_join_index(self):
6161
# left / right
6262

6363
f = self.frame.reindex(columns=['A', 'B'])[:10]
64-
f2 = self.frame.reindex(columns=['C', 'D'])
64+
f2 = self.frame.reindex(columns=['C', 'D'])[5:][::-1]
6565

6666
joined = f.join(f2)
6767
self.assert_index_equal(f.index, joined.index)
68-
self.assertEqual(len(joined.columns), 4)
68+
expected_columns = pd.Index(['A', 'B', 'C', 'D'])
69+
self.assert_index_equal(joined.columns, expected_columns)
6970

7071
joined = f.join(f2, how='left')
7172
self.assert_index_equal(joined.index, f.index)
72-
self.assertEqual(len(joined.columns), 4)
73+
self.assert_index_equal(joined.columns, expected_columns)
7374

7475
joined = f.join(f2, how='right')
7576
self.assert_index_equal(joined.index, f2.index)
76-
self.assertEqual(len(joined.columns), 4)
77+
self.assert_index_equal(joined.columns, expected_columns)
7778

7879
# inner
7980

80-
f = self.frame.reindex(columns=['A', 'B'])[:10]
81-
f2 = self.frame.reindex(columns=['C', 'D'])
82-
8381
joined = f.join(f2, how='inner')
8482
self.assert_index_equal(joined.index, f.index.intersection(f2.index))
85-
self.assertEqual(len(joined.columns), 4)
83+
self.assert_index_equal(joined.columns, expected_columns)
8684

8785
# outer
8886

89-
f = self.frame.reindex(columns=['A', 'B'])[:10]
90-
f2 = self.frame.reindex(columns=['C', 'D'])
91-
9287
joined = f.join(f2, how='outer')
93-
self.assertTrue(tm.equalContents(self.frame.index, joined.index))
94-
self.assertEqual(len(joined.columns), 4)
88+
self..assert_index_equal(joined.index, self.frame.index.sort_values())
89+
self.assert_index_equal(joined.columns, expected_columns)
9590

9691
assertRaisesRegexp(ValueError, 'join method', f.join, f2, how='foo')
9792

pandas/tests/indexes/test_base.py

+9-7
Original file line numberDiff line numberDiff line change
@@ -626,14 +626,16 @@ def test_intersection(self):
626626
# non monotonic
627627
idx1 = Index([5, 3, 2, 4, 1], name='idx')
628628
idx2 = Index([4, 7, 6, 5, 3], name='idx')
629-
result2 = idx1.intersection(idx2)
630-
self.assertTrue(tm.equalContents(result2, expected2))
631-
self.assertEqual(result2.name, expected2.name)
629+
expected = Index([5, 3, 4], name='idx')
630+
result = idx1.intersection(idx2)
631+
self.assert_index_equal(result, expected)
632+
self.assertEqual(result.name, expected.name)
632633

633-
idx3 = Index([4, 7, 6, 5, 3], name='other')
634-
result3 = idx1.intersection(idx3)
635-
self.assertTrue(tm.equalContents(result3, expected3))
636-
self.assertEqual(result3.name, expected3.name)
634+
idx2 = Index([4, 7, 6, 5, 3], name='other')
635+
expected = Index([5, 3, 4], name=None)
636+
result = idx1.intersection(idx2)
637+
self.assert_index_equal(result, expected)
638+
self.assertEqual(result.name, expected.name)
637639

638640
# non-monotonic non-unique
639641
idx1 = Index(['A', 'B', 'A', 'C'])

0 commit comments

Comments
 (0)