Skip to content

Commit c282377

Browse files
CLN: changed type hints to fix mypy errors
1 parent 7dbaa4d commit c282377

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

pandas/core/indexes/base.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -4524,7 +4524,7 @@ def asof_locs(self, where, mask):
45244524

45254525
return result
45264526

4527-
def sort_values(self, return_indexer=False, ascending=True, key : Union[Callable, None] = None):
4527+
def sort_values(self, return_indexer=False, ascending=True, key : Callable = None):
45284528
"""
45294529
Return a sorted copy of the index.
45304530
@@ -4537,8 +4537,9 @@ def sort_values(self, return_indexer=False, ascending=True, key : Union[Callable
45374537
Should the indices that would sort the index be returned.
45384538
ascending : bool, default True
45394539
Should the index values be sorted in an ascending order.
4540-
key : Union[Callable, None] , default None
4541-
Apply a key function to the indices before sorting, like sorted.
4540+
key : Callable, default None
4541+
Apply a key function to the indices before sorting, like
4542+
built-in sorted function.
45424543
45434544
Returns
45444545
-------

pandas/core/series.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -3019,7 +3019,7 @@ def sort_values(
30193019
inplace=False,
30203020
kind="quicksort",
30213021
na_position="last",
3022-
key: Union[Callable, None] = None
3022+
key: Callable = None
30233023
):
30243024
"""
30253025
Sort by the values.
@@ -3042,7 +3042,7 @@ def sort_values(
30423042
na_position : {'first' or 'last'}, default 'last'
30433043
Argument 'first' puts NaNs at the beginning, 'last' puts NaNs at
30443044
the end.
3045-
key : Union[Callable, None], default None
3045+
key : Callable, default None
30463046
If not None, apply the key function to every value before
30473047
sorting. Identical to key argument in built-in sorted function.
30483048
@@ -3220,7 +3220,7 @@ def sort_index(
32203220
kind="quicksort",
32213221
na_position="last",
32223222
sort_remaining=True,
3223-
key : Union[Callable, None] = None
3223+
key : Callable = None
32243224
):
32253225
"""
32263226
Sort Series by index labels.
@@ -3249,7 +3249,7 @@ def sort_index(
32493249
sort_remaining : bool, default True
32503250
If True and sorting by level and index is multilevel, sort by other
32513251
levels too (in order) after sorting by specified level.
3252-
key : Union[Callable, None], default None
3252+
key : Callable, default None
32533253
If not None, apply the key function to every index element before
32543254
sorting. Identical to key argument in built-in sorted function.
32553255

pandas/core/sorting.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ def lexsort_indexer(keys, orders=None, na_position="last", key : Union[Callable,
202202

203203
if key:
204204
key_func = np.vectorize(key)
205-
keys = [key_func(key) if key.size != 0 else key for key in keys]
205+
keys = [key_func(entry) if entry.size != 0 else entry for entry in keys]
206206

207207
for key, order in zip(keys, orders):
208208

pandas/tests/frame/test_sorting.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@ def test_sort_value_key_nan(self):
652652
@pytest.mark.parametrize('key', [None, lambda x : x])
653653
def test_sort_value_key_empty(self, key):
654654
df = DataFrame(np.array([]))
655-
655+
656656
df.sort_values(0, key=key)
657657
df.sort_index(key=key)
658658

0 commit comments

Comments
 (0)