Skip to content

Commit c20e800

Browse files
committed
Fix tests
1 parent bbf4964 commit c20e800

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

pandas/tests/strings/test_string_array.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import pytest
33

44
from pandas._libs import lib
5+
from pandas.compat import pa_version_under11p0
56

67
from pandas import (
78
NA,
@@ -13,7 +14,7 @@
1314

1415

1516
@pytest.mark.filterwarnings("ignore:Falling back")
16-
def test_string_array(nullable_string_dtype, any_string_method):
17+
def test_string_array(nullable_string_dtype, any_string_method, request):
1718
method_name, args, kwargs = any_string_method
1819

1920
data = ["a", "bb", np.nan, "ccc"]
@@ -25,6 +26,10 @@ def test_string_array(nullable_string_dtype, any_string_method):
2526
getattr(b.str, method_name)(*args, **kwargs)
2627
return
2728

29+
if b.dtype.storage == "pyarrow" and pa_version_under11p0 and method_name == "slice":
30+
mark = pytest.mark.xfail(reason="Negative buffer resize")
31+
request.applymarker(mark)
32+
2833
expected = getattr(a.str, method_name)(*args, **kwargs)
2934
result = getattr(b.str, method_name)(*args, **kwargs)
3035

pandas/tests/strings/test_strings.py

+6-3
Original file line numberDiff line numberDiff line change
@@ -395,19 +395,22 @@ def test_pipe_failures(any_string_dtype):
395395
[
396396
(2, 5, None, ["foo", "bar", np.nan, "baz"]),
397397
(0, 3, -1, ["", "", np.nan, ""]),
398-
pytest.param(
398+
(
399399
None,
400400
None,
401401
-1,
402402
["owtoofaa", "owtrabaa", np.nan, "xuqzabaa"],
403-
marks=pytest.mark.xfail(pa_version_under11p0, reason="Empty result"),
404403
),
405404
(3, 10, 2, ["oto", "ato", np.nan, "aqx"]),
406405
(3, 0, -1, ["ofa", "aba", np.nan, "aba"]),
407406
],
408407
)
409-
def test_slice(start, stop, step, expected, any_string_dtype):
408+
def test_slice(start, stop, step, expected, any_string_dtype, request):
410409
ser = Series(["aafootwo", "aabartwo", np.nan, "aabazqux"], dtype=any_string_dtype)
410+
if any_string_dtype == "string[pyarrow]" and pa_version_under11p0:
411+
mark = pytest.mark.xfail(reason="Empty result")
412+
request.applymarker(mark)
413+
411414
result = ser.str.slice(start, stop, step)
412415
expected = Series(expected, dtype=any_string_dtype)
413416
tm.assert_series_equal(result, expected)

0 commit comments

Comments
 (0)