Skip to content

Commit bf1e927

Browse files
committed
Change docstring and move the entry in whatsnew
1 parent d1dd5fa commit bf1e927

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

doc/source/whatsnew/v0.25.0.rst

+5-1
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ Other Enhancements
8282
- :meth:`DataFrame.query` and :meth:`DataFrame.eval` now supports quoting column names with backticks to refer to names with spaces (:issue:`6508`)
8383
- :func:`merge_asof` now gives a more clear error message when merge keys are categoricals that are not equal (:issue:`26136`)
8484
- :meth:`pandas.core.window.Rolling` supports exponential (or Poisson) window type (:issue:`21303`)
85+
<<<<<<< HEAD
8586
- :meth:`ExtensionArray.argsort` places NA values at the end of the sorted array (:issue:`21801`)
86-
>>>>>>> Add whatsnew note
8787

8888
.. _whatsnew_0250.api_breaking:
8989

@@ -435,10 +435,14 @@ Other API Changes
435435
- Comparing :class:`Timestamp` with unsupported objects now returns :py:obj:`NotImplemented` instead of raising ``TypeError``. This implies that unsupported rich comparisons are delegated to the other object, and are now consistent with Python 3 behavior for ``datetime`` objects (:issue:`24011`)
436436
- Bug in :meth:`DatetimeIndex.snap` which didn't preserving the ``name`` of the input :class:`Index` (:issue:`25575`)
437437
- The ``arg`` argument in :meth:`pandas.core.groupby.DataFrameGroupBy.agg` has been renamed to ``func`` (:issue:`26089`)
438+
<<<<<<< HEAD
438439
- The ``arg`` argument in :meth:`pandas.core.window._Window.aggregate` has been renamed to ``func`` (:issue:`26372`)
439440
- Most Pandas classes had a ``__bytes__`` method, which was used for getting a python2-style bytestring representation of the object. This method has been removed as a part of dropping Python2 (:issue:`26447`)
440441
- The ``.str``-accessor has been disabled for 1-level :class:`MultiIndex`, use :meth:`MultiIndex.to_flat_index` if necessary (:issue:`23679`)
441442
- Removed support of gtk package for clipboards (:issue:`26563`)
443+
=======
444+
- :meth:`ExtensionArray.argsort` places the nan at the end of the sorted array (:issue:`21801`)
445+
>>>>>>> Change docstring and move the entry in whatsnew
442446

443447
.. _whatsnew_0250.deprecations:
444448

pandas/core/arrays/base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ def _values_for_argsort(self) -> Tuple[np.ndarray, np.ndarray]:
371371
The transformed values should maintain the ordering between values
372372
within the array.
373373
ndarray
374-
The mask which indicates the NaN values.
374+
The mask which indicates the NA values.
375375
376376
See Also
377377
--------

pandas/core/arrays/integer.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ def _values_for_argsort(self) -> Tuple[np.ndarray, np.ndarray]:
521521
The transformed values should maintain the ordering between values
522522
within the array.
523523
ndarray
524-
The mask which indicates the NaN values.
524+
The mask which indicates the NA values.
525525
526526
See Also
527527
--------

0 commit comments

Comments
 (0)