Skip to content

Commit ba5031e

Browse files
authored
STYLE: fix pylint no-else-break warnings (#49237)
1 parent bb858da commit ba5031e

File tree

5 files changed

+34
-37
lines changed

5 files changed

+34
-37
lines changed

pandas/io/parsers/python_parser.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,7 @@ def _next_line(self) -> list[Scalar]:
704704
self._is_line_empty(self.data[self.pos - 1]) or line
705705
):
706706
break
707-
elif self.skip_blank_lines:
707+
if self.skip_blank_lines:
708708
ret = self._remove_empty_lines([line])
709709
if ret:
710710
line = ret[0]

pandas/io/sql.py

+29-29
Original file line numberDiff line numberDiff line change
@@ -971,18 +971,18 @@ def _query_iterator(
971971
[], columns=columns, coerce_float=coerce_float
972972
)
973973
break
974-
else:
975-
has_read_data = True
976-
self.frame = DataFrame.from_records(
977-
data, columns=columns, coerce_float=coerce_float
978-
)
979974

980-
self._harmonize_columns(parse_dates=parse_dates)
975+
has_read_data = True
976+
self.frame = DataFrame.from_records(
977+
data, columns=columns, coerce_float=coerce_float
978+
)
981979

982-
if self.index is not None:
983-
self.frame.set_index(self.index, inplace=True)
980+
self._harmonize_columns(parse_dates=parse_dates)
981+
982+
if self.index is not None:
983+
self.frame.set_index(self.index, inplace=True)
984984

985-
yield self.frame
985+
yield self.frame
986986

987987
def read(
988988
self,
@@ -1489,16 +1489,16 @@ def _query_iterator(
14891489
parse_dates=parse_dates,
14901490
)
14911491
break
1492-
else:
1493-
has_read_data = True
1494-
yield _wrap_result(
1495-
data,
1496-
columns,
1497-
index_col=index_col,
1498-
coerce_float=coerce_float,
1499-
parse_dates=parse_dates,
1500-
dtype=dtype,
1501-
)
1492+
1493+
has_read_data = True
1494+
yield _wrap_result(
1495+
data,
1496+
columns,
1497+
index_col=index_col,
1498+
coerce_float=coerce_float,
1499+
parse_dates=parse_dates,
1500+
dtype=dtype,
1501+
)
15021502

15031503
def read_query(
15041504
self,
@@ -2053,16 +2053,16 @@ def _query_iterator(
20532053
[], columns=columns, coerce_float=coerce_float
20542054
)
20552055
break
2056-
else:
2057-
has_read_data = True
2058-
yield _wrap_result(
2059-
data,
2060-
columns,
2061-
index_col=index_col,
2062-
coerce_float=coerce_float,
2063-
parse_dates=parse_dates,
2064-
dtype=dtype,
2065-
)
2056+
2057+
has_read_data = True
2058+
yield _wrap_result(
2059+
data,
2060+
columns,
2061+
index_col=index_col,
2062+
coerce_float=coerce_float,
2063+
parse_dates=parse_dates,
2064+
dtype=dtype,
2065+
)
20662066

20672067
def read_query(
20682068
self,

pandas/plotting/_matplotlib/converter.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -404,9 +404,8 @@ def __call__(self):
404404
if num <= interval * (max_millis_ticks - 1):
405405
self._interval = interval
406406
break
407-
else:
408-
# We went through the whole loop without breaking, default to 1
409-
self._interval = 1000.0
407+
# We went through the whole loop without breaking, default to 1
408+
self._interval = 1000.0
410409

411410
estimate = (nmax - nmin) / (self._get_unit() * self._get_interval())
412411

pandas/tests/io/test_user_agent.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -233,9 +233,8 @@ def responder(request):
233233
if wait_time > kill_time:
234234
server_process.kill()
235235
break
236-
else:
237-
wait_time += 0.1
238-
time.sleep(0.1)
236+
wait_time += 0.1
237+
time.sleep(0.1)
239238
server_process.close()
240239

241240

pyproject.toml

-1
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ disable = [
122122
"inconsistent-return-statements",
123123
"invalid-sequence-index",
124124
"literal-comparison",
125-
"no-else-break",
126125
"no-else-continue",
127126
"no-else-raise",
128127
"no-else-return",

0 commit comments

Comments
 (0)