Skip to content

Commit b8a8049

Browse files
authored
REF: dont call maybe_promote with EA dtype (#44606)
1 parent 4b97acb commit b8a8049

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pandas/core/reshape/reshape.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -245,24 +245,24 @@ def get_new_values(self, values, fill_value=None):
245245
new_mask = np.ones(result_shape, dtype=bool)
246246
return new_values, new_mask
247247

248+
dtype = values.dtype
249+
248250
# if our mask is all True, then we can use our existing dtype
249251
if mask_all:
250252
dtype = values.dtype
251253
new_values = np.empty(result_shape, dtype=dtype)
252-
name = np.dtype(dtype).name
253254
else:
254-
dtype, fill_value = maybe_promote(values.dtype, fill_value)
255255
if isinstance(dtype, ExtensionDtype):
256256
# GH#41875
257257
cls = dtype.construct_array_type()
258258
new_values = cls._empty(result_shape, dtype=dtype)
259259
new_values[:] = fill_value
260-
name = dtype.name
261260
else:
261+
dtype, fill_value = maybe_promote(dtype, fill_value)
262262
new_values = np.empty(result_shape, dtype=dtype)
263263
new_values.fill(fill_value)
264-
name = np.dtype(dtype).name
265264

265+
name = dtype.name
266266
new_mask = np.zeros(result_shape, dtype=bool)
267267

268268
# we need to convert to a basic dtype

0 commit comments

Comments
 (0)