Skip to content

Commit b8981f4

Browse files
authored
TYP: typing errors in _xlsxwriter.py #35994 (#35995)
* TYP: typing errors in _xlsxwriter.py #35994 * TYP: add param type * TYP: remove book=None in base class
1 parent 6043ba5 commit b8981f4

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

pandas/io/excel/_base.py

-1
Original file line numberDiff line numberDiff line change
@@ -653,7 +653,6 @@ def __new__(cls, path, engine=None, **kwargs):
653653
return object.__new__(cls)
654654

655655
# declare external properties you can count on
656-
book = None
657656
curr_sheet = None
658657
path = None
659658

pandas/io/excel/_odswriter.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def __init__(
2525

2626
super().__init__(path, mode=mode, **engine_kwargs)
2727

28-
self.book: OpenDocumentSpreadsheet = OpenDocumentSpreadsheet()
28+
self.book = OpenDocumentSpreadsheet()
2929
self._style_dict: Dict[str, str] = {}
3030

3131
def save(self) -> None:

pandas/io/excel/_xlsxwriter.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from typing import Dict, List, Tuple
2+
13
import pandas._libs.json as json
24

35
from pandas.io.excel._base import ExcelWriter
@@ -8,7 +10,7 @@ class _XlsxStyler:
810
# Map from openpyxl-oriented styles to flatter xlsxwriter representation
911
# Ordering necessary for both determinism and because some are keyed by
1012
# prefixes of others.
11-
STYLE_MAPPING = {
13+
STYLE_MAPPING: Dict[str, List[Tuple[Tuple[str, ...], str]]] = {
1214
"font": [
1315
(("name",), "font_name"),
1416
(("sz",), "font_size"),
@@ -170,7 +172,7 @@ def __init__(
170172
**engine_kwargs,
171173
):
172174
# Use the xlsxwriter module as the Excel writer.
173-
import xlsxwriter
175+
from xlsxwriter import Workbook
174176

175177
if mode == "a":
176178
raise ValueError("Append mode is not supported with xlsxwriter!")
@@ -184,7 +186,7 @@ def __init__(
184186
**engine_kwargs,
185187
)
186188

187-
self.book = xlsxwriter.Workbook(path, **engine_kwargs)
189+
self.book = Workbook(path, **engine_kwargs)
188190

189191
def save(self):
190192
"""

0 commit comments

Comments
 (0)