CLN: address TODOs (#33886)

Author: jbrockmendel

pandas/_libs/lib.pyx

@@ -589,7 +589,7 @@ def array_equivalent_object(left: object[:], right: object[:]) -> bool:
         except TypeError as err:
             # Avoid raising TypeError on tzawareness mismatch
             # TODO: This try/except can be removed if/when Timestamp
-            #  comparisons are change dto match datetime, see GH#28507
+            #  comparisons are changed to match datetime, see GH#28507
             if "tz-naive and tz-aware" in str(err):
                 return False
             raise
@@ -2346,8 +2346,6 @@ def map_infer_mask(ndarray arr, object f, const uint8_t[:] mask, bint convert=Tr
 
             if cnp.PyArray_IsZeroDim(val):
                 # unbox 0-dim arrays, GH#690
-                # TODO: is there a faster way to unbox?
-                #   item_from_zerodim?
                 val = val.item()
 
         result[i] = val
@@ -2388,8 +2386,6 @@ def map_infer(ndarray arr, object f, bint convert=True):
 
         if cnp.PyArray_IsZeroDim(val):
             # unbox 0-dim arrays, GH#690
-            # TODO: is there a faster way to unbox?
-            #   item_from_zerodim?
             val = val.item()
 
         result[i] = val

pandas/_libs/tslibs/timedeltas.pyx

@@ -1516,10 +1516,6 @@ class Timedelta(_Timedelta):
 
     def __rmod__(self, other):
         # Naive implementation, room for optimization
-        if hasattr(other, 'dtype') and other.dtype.kind == 'i':
-            # TODO: Remove this check with backwards-compat shim
-            # for integer / Timedelta is removed.
-            raise TypeError(f'Invalid dtype {other.dtype} for __mod__')
         return self.__rdivmod__(other)[1]
 
     def __divmod__(self, other):
@@ -1529,10 +1525,6 @@ class Timedelta(_Timedelta):
 
     def __rdivmod__(self, other):
         # Naive implementation, room for optimization
-        if hasattr(other, 'dtype') and other.dtype.kind == 'i':
-            # TODO: Remove this check with backwards-compat shim
-            # for integer / Timedelta is removed.
-            raise TypeError(f'Invalid dtype {other.dtype} for __mod__')
         div = other // self
         return div, other - div * self
 

pandas/core/arrays/datetimelike.py

@@ -1511,13 +1511,9 @@ def __rsub__(self, other):
             # TODO: Can we simplify/generalize these cases at all?
             raise TypeError(f"cannot subtract {type(self).__name__} from {other.dtype}")
         elif is_timedelta64_dtype(self.dtype):
-            if lib.is_integer(other) or is_integer_dtype(other):
-                # need to subtract before negating, since that flips freq
-                # -self flips self.freq, messing up results
-                return -(self - other)
-
             return (-self) + other
 
+        # We get here with e.g. datetime objects
         return -(self - other)
 
     def __iadd__(self, other):

pandas/core/frame.py

@@ -8989,7 +8989,6 @@ def _AXIS_NAMES(self) -> Dict[int, str]:
 
 
 def _from_nested_dict(data):
-    # TODO: this should be seriously cythonized
     new_data = collections.defaultdict(dict)
     for index, s in data.items():
         for col, v in s.items():

pandas/core/indexes/base.py

@@ -151,7 +151,6 @@ def index_arithmetic_method(self, other):
         return Index(result)
 
     name = f"__{op.__name__}__"
-    # TODO: docstring?
     return set_function_name(index_arithmetic_method, name, cls)
 
 

pandas/core/indexes/period.py

@@ -668,10 +668,14 @@ def intersection(self, other, sort=False):
         if self.equals(other):
             return self._get_reconciled_name_object(other)
 
-        if not is_dtype_equal(self.dtype, other.dtype):
-            # TODO: fastpath for if we have a different PeriodDtype
-            this = self.astype("O")
-            other = other.astype("O")
+        elif is_object_dtype(other.dtype):
+            return self.astype("O").intersection(other, sort=sort)
+
+        elif not is_dtype_equal(self.dtype, other.dtype):
+            # We can infer that the intersection is empty.
+            # assert_can_do_setop ensures that this is not just a mismatched freq
+            this = self[:0].astype("O")
+            other = other[:0].astype("O")
             return this.intersection(other, sort=sort)
 
         return self._setop(other, sort, opname="intersection")

pandas/core/internals/concat.py

@@ -1,4 +1,3 @@
-# TODO: Needs a better name; too many modules are already called "concat"
 from collections import defaultdict
 import copy
 from typing import List

pandas/io/sas/sasreader.py

@@ -7,7 +7,7 @@
 from pandas.io.common import stringify_path
 
 
-# TODO: replace with Protocol in Python 3.8
+# TODO(PY38): replace with Protocol in Python 3.8
 class ReaderBase(metaclass=ABCMeta):
     """
     Protocol for XportReader and SAS7BDATReader classes.