TST: refactored html tests

Author: TomAugspurger

pandas/tests/io/test_html.py

@@ -28,6 +28,22 @@
 HERE = os.path.dirname(__file__)
 
 
+def pytest_generate_tests(metafunc):
+    # Defers evaluation of the fixture until after collection.
+    # https://docs.pytest.org/en/latest/example/parametrize.html\
+    # deferring-the-setup-of-parametrized-resources
+    if 'html_file' in metafunc.fixturenames:
+        paths = glob.glob(
+            os.path.join(HERE, 'data', 'html_encoding', '*.html')
+        )
+        metafunc.parametrize("html_file", paths, indirect=True)
+
+
+@pytest.fixture
+def html_file(request, datapath):
+    return datapath(request.param)
+
+
 def assert_framelist_equal(list1, list2, *args, **kwargs):
     assert len(list1) == len(list2), ('lists are not of equal size '
                                       'len(list1) == {0}, '
@@ -838,22 +854,22 @@ def test_displayed_only(self, displayed_only, exp0, exp1):
         else:
             assert len(dfs) == 1  # Should not parse hidden table
 
-    @pytest.mark.parametrize("f", glob.glob(
-        os.path.join(HERE, 'data', 'html_encoding', '*.html')))
-    def test_encode(self, f):
-        _, encoding = os.path.splitext(os.path.basename(f))[0].split('_')
+    def test_encode(self, html_file):
+        _, encoding = os.path.splitext(
+            os.path.basename(html_file)
+        )[0].split('_')
 
         try:
-            with open(f, 'rb') as fobj:
+            with open(html_file, 'rb') as fobj:
                 from_string = self.read_html(fobj.read(), encoding=encoding,
                                              index_col=0).pop()
 
-            with open(f, 'rb') as fobj:
+            with open(html_file, 'rb') as fobj:
                 from_file_like = self.read_html(BytesIO(fobj.read()),
                                                 encoding=encoding,
                                                 index_col=0).pop()
 
-            from_filename = self.read_html(f, encoding=encoding,
+            from_filename = self.read_html(html_file, encoding=encoding,
                                            index_col=0).pop()
             tm.assert_frame_equal(from_string, from_file_like)
             tm.assert_frame_equal(from_string, from_filename)

pandas/tests/io/test_packers.py

@@ -928,7 +928,8 @@ def test_msgpacks_legacy(self, current_packers_data, all_packers_data,
         # GH12142 0.17 files packed in P2 can't be read in P3
         if (compat.PY3 and version.startswith('0.17.') and
                 legacy_packer.split('.')[-4][-1] == '2'):
-            pytest.skip("Files packed in Py2 can't be read in Py3.")
+            msg = "Files packed in Py2 can't be read in Py3 ({})"
+            pytest.skip(msg.format(version))
         try:
             with catch_warnings(record=True):
                 self.compare(current_packers_data, all_packers_data,

test_foo.py

@@ -0,0 +1,22 @@
+import pytest
+
+CALL_COUNT = 0 
+
+
+@pytest.fixture(scope="module")
+def fixture(request, datapath):
+    global CALL_COUNT
+    CALL_COUNT += 1 
+
+    return request.param
+
+
+def pytest_generate_tests(metafunc):
+    if "fixture" in metafunc.fixturenames:
+        metafunc.parametrize("fixture", ["foo"], indirect=True, scope="module")
+
+
+@pytest.mark.parametrize("param", ["bar", "zaz"])
+def test_1(fixture, param):
+    global CALL_COUNT
+    assert CALL_COUNT == 1