Rephrase whatsnew entry, move tests

Author: MarcoGorelli

doc/source/whatsnew/v1.0.0.rst

@@ -133,7 +133,9 @@ Categorical
 
 - Added test to assert the :func:`fillna` raises the correct ValueError message when the value isn't a value from categories (:issue:`13628`)
 - Bug in :meth:`Categorical.astype` where ``NaN`` values were handled incorrectly when casting to int (:issue:`28406`)
--
+- Using date accessors on a categorical dtyped series of datetimes was not returning a Series (or DataFrame) of the
+  same type as if one used the .str. / .dt. on a Series of that type, e.g. when accessing :meth:`Series.dt.tz_localize` on a
+  :class:`Categorical` with duplicate entries, the accessor was skipping duplicates (:issue: `27952`)
 -
 
 

pandas/tests/indexes/test_category.py

@@ -1123,36 +1123,3 @@ def test_engine_type(self, dtype, engine_type):
             ci.values._codes = ci.values._codes.astype("int64")
         assert np.issubdtype(ci.codes.dtype, dtype)
         assert isinstance(ci._engine, engine_type)
-
-    def test_dt_tz_localize(self, tz_aware_fixture):
-        # GH 27952
-        tz = tz_aware_fixture
-        datetimes = pd.Series(
-            ["2019-01-01", "2019-01-01", "2019-01-02"], dtype="datetime64[ns]"
-        )
-        categorical = datetimes.astype("category")
-        result = categorical.dt.tz_localize(tz)
-        expected = datetimes.dt.tz_localize(tz)
-        tm.assert_series_equal(result, expected)
-
-    def test_dt_tz_convert(self, tz_aware_fixture):
-        # GH 27952
-        tz = tz_aware_fixture
-        datetimes = pd.Series(
-            ["2019-01-01", "2019-01-01", "2019-01-02"], dtype="datetime64[ns, MET]"
-        )
-        categorical = datetimes.astype("category")
-        result = categorical.dt.tz_convert(tz)
-        expected = datetimes.dt.tz_convert(tz)
-        tm.assert_series_equal(result, expected)
-
-    @pytest.mark.parametrize("accessor", ["year", "month", "day"])
-    def test_dt_other_accessors(self, accessor):
-        # GH 27952
-        datetimes = pd.Series(
-            ["2018-01-01", "2018-01-01", "2019-01-02"], dtype="datetime64[ns]"
-        )
-        categorical = datetimes.astype("category")
-        result = getattr(categorical.dt, accessor)
-        expected = getattr(datetimes.dt, accessor)
-        tm.assert_series_equal(result, expected)

pandas/tests/series/test_datetime_values.py

@@ -345,6 +345,72 @@ def test_dt_namespace_accessor_categorical(self):
         expected = Series([2017, 2017, 2018, 2018], name="foo")
         tm.assert_series_equal(result, expected)
 
+    def test_dt_tz_localize(self, tz_aware_fixture):
+        # GH 27952
+        tz = tz_aware_fixture
+        datetimes = pd.Series(
+            ["2019-01-01", "2019-01-01", "2019-01-02"], dtype="datetime64[ns]"
+        )
+        categorical = datetimes.astype("category")
+        result = categorical.dt.tz_localize(tz)
+        expected = datetimes.dt.tz_localize(tz)
+        tm.assert_series_equal(result, expected)
+
+    def test_dt_tz_convert(self, tz_aware_fixture):
+        # GH 27952
+        tz = tz_aware_fixture
+        datetimes = pd.Series(
+            ["2019-01-01", "2019-01-01", "2019-01-02"], dtype="datetime64[ns, MET]"
+        )
+        categorical = datetimes.astype("category")
+        result = categorical.dt.tz_convert(tz)
+        expected = datetimes.dt.tz_convert(tz)
+        tm.assert_series_equal(result, expected)
+
+    @pytest.mark.parametrize("accessor", ["year", "month", "day"])
+    def test_dt_other_accessors(self, accessor):
+        # GH 27952
+        datetimes = pd.Series(
+            ["2018-01-01", "2018-01-01", "2019-01-02"], dtype="datetime64[ns]"
+        )
+        categorical = datetimes.astype("category")
+        result = getattr(categorical.dt, accessor)
+        expected = getattr(datetimes.dt, accessor)
+        tm.assert_series_equal(result, expected)
+
+    def test_dt_tz_localize(self, tz_aware_fixture):
+        # GH 27952
+        tz = tz_aware_fixture
+        datetimes = pd.Series(
+            ["2019-01-01", "2019-01-01", "2019-01-02"], dtype="datetime64[ns]"
+        )
+        categorical = datetimes.astype("category")
+        result = categorical.dt.tz_localize(tz)
+        expected = datetimes.dt.tz_localize(tz)
+        tm.assert_series_equal(result, expected)
+
+    def test_dt_tz_convert(self, tz_aware_fixture):
+        # GH 27952
+        tz = tz_aware_fixture
+        datetimes = pd.Series(
+            ["2019-01-01", "2019-01-01", "2019-01-02"], dtype="datetime64[ns, MET]"
+        )
+        categorical = datetimes.astype("category")
+        result = categorical.dt.tz_convert(tz)
+        expected = datetimes.dt.tz_convert(tz)
+        tm.assert_series_equal(result, expected)
+
+    @pytest.mark.parametrize("accessor", ["year", "month", "day"])
+    def test_dt_other_accessors(self, accessor):
+        # GH 27952
+        datetimes = pd.Series(
+            ["2018-01-01", "2018-01-01", "2019-01-02"], dtype="datetime64[ns]"
+        )
+        categorical = datetimes.astype("category")
+        result = getattr(categorical.dt, accessor)
+        expected = getattr(datetimes.dt, accessor)
+        tm.assert_series_equal(result, expected)
+
     def test_dt_accessor_no_new_attributes(self):
         # https://github.com/pandas-dev/pandas/issues/10673
         s = Series(date_range("20130101", periods=5, freq="D"))