Skip to content

Commit b313f0c

Browse files
Blake HawkinsWillAyd
Blake Hawkins
authored andcommitted
Fix mypy errors in testcommon py (#29179)
1 parent 7acf607 commit b313f0c

File tree

2 files changed

+17
-6
lines changed

2 files changed

+17
-6
lines changed

pandas/tests/dtypes/test_common.py

+17-3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from typing import List
2+
13
import numpy as np
24
import pytest
35

@@ -322,9 +324,13 @@ def test_is_datetimelike():
322324
assert com.is_datetimelike(s)
323325

324326

327+
integer_dtypes = [] # type: List
328+
329+
325330
@pytest.mark.parametrize(
326331
"dtype",
327-
[pd.Series([1, 2])]
332+
integer_dtypes
333+
+ [pd.Series([1, 2])]
328334
+ ALL_INT_DTYPES
329335
+ to_numpy_dtypes(ALL_INT_DTYPES)
330336
+ ALL_EA_INT_DTYPES
@@ -350,9 +356,13 @@ def test_is_not_integer_dtype(dtype):
350356
assert not com.is_integer_dtype(dtype)
351357

352358

359+
signed_integer_dtypes = [] # type: List
360+
361+
353362
@pytest.mark.parametrize(
354363
"dtype",
355-
[pd.Series([1, 2])]
364+
signed_integer_dtypes
365+
+ [pd.Series([1, 2])]
356366
+ SIGNED_INT_DTYPES
357367
+ to_numpy_dtypes(SIGNED_INT_DTYPES)
358368
+ SIGNED_EA_INT_DTYPES
@@ -382,9 +392,13 @@ def test_is_not_signed_integer_dtype(dtype):
382392
assert not com.is_signed_integer_dtype(dtype)
383393

384394

395+
unsigned_integer_dtypes = [] # type: List
396+
397+
385398
@pytest.mark.parametrize(
386399
"dtype",
387-
[pd.Series([1, 2], dtype=np.uint32)]
400+
unsigned_integer_dtypes
401+
+ [pd.Series([1, 2], dtype=np.uint32)]
388402
+ UNSIGNED_INT_DTYPES
389403
+ to_numpy_dtypes(UNSIGNED_INT_DTYPES)
390404
+ UNSIGNED_EA_INT_DTYPES

setup.cfg

-3
Original file line numberDiff line numberDiff line change
@@ -136,9 +136,6 @@ ignore_errors=True
136136
[mypy-pandas.tests.arithmetic.test_datetime64]
137137
ignore_errors=True
138138

139-
[mypy-pandas.tests.dtypes.test_common]
140-
ignore_errors=True
141-
142139
[mypy-pandas.tests.extension.decimal.test_decimal]
143140
ignore_errors=True
144141

0 commit comments

Comments
 (0)