Skip to content

Commit b196a09

Browse files
authored
ENH: Do unique check before computing indexer in reindex (#51304)
* ENH: Do unique check before computing indexer in reindex * Refactor
1 parent 8d1b7fc commit b196a09

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

pandas/core/indexes/base.py

+3-9
Original file line numberDiff line numberDiff line change
@@ -4238,17 +4238,11 @@ def reindex(
42384238
)
42394239
elif self._is_multi:
42404240
raise ValueError("cannot handle a non-unique multi-index!")
4241-
else:
4242-
if method is not None or limit is not None:
4243-
raise ValueError(
4244-
"cannot reindex a non-unique index "
4245-
"with a method or limit"
4246-
)
4247-
indexer, _ = self.get_indexer_non_unique(target)
4248-
4249-
if not self.is_unique:
4241+
elif not self.is_unique:
42504242
# GH#42568
42514243
raise ValueError("cannot reindex on an axis with duplicate labels")
4244+
else:
4245+
indexer, _ = self.get_indexer_non_unique(target)
42524246

42534247
target = self._wrap_reindex_result(target, indexer, preserve_names)
42544248
return target, indexer

0 commit comments

Comments
 (0)