Skip to content

Commit b106895

Browse files
committed
fixup: Remove assert_produces_warning in tests because not raised???
1 parent 8a158a0 commit b106895

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

pandas/tests/sparse/test_frame.py

+3-8
Original file line numberDiff line numberDiff line change
@@ -1399,7 +1399,7 @@ def test_numpy_func_call(self):
13991399
getattr(np, func)(self.frame)
14001400

14011401

1402-
def _test_assignment(kind, indexer, key=None, expect_warning=True):
1402+
def _test_assignment(kind, indexer, key=None):
14031403
arr = np.array([[1, nan],
14041404
[nan, 1]])
14051405
df = DataFrame(arr, copy=True)
@@ -1411,11 +1411,7 @@ def get_indexer(df):
14111411
if key is None:
14121412
key = pd.isnull(sdf).to_sparse()
14131413

1414-
if expect_warning:
1415-
with tm.assert_produces_warning(PerformanceWarning):
1416-
get_indexer(sdf)[key] = 2
1417-
else:
1418-
get_indexer(sdf)[key] = 2
1414+
get_indexer(sdf)[key] = 2
14191415

14201416
get_indexer(df)[key] = 2
14211417
res = df.to_sparse(kind=kind)
@@ -1448,5 +1444,4 @@ def test_frame_assignment_setitem(spindex_kind, key):
14481444
@pytest.mark.parametrize('indexer', ['loc', 'at'])
14491445
@pytest.mark.parametrize('key', [3])
14501446
def test_frame_assignment_extend_index(spindex_kind, indexer, key):
1451-
_test_assignment(spindex_kind, indexer, key,
1452-
expect_warning=indexer == 'at')
1447+
_test_assignment(spindex_kind, indexer, key)

pandas/tests/sparse/test_series.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -1452,7 +1452,6 @@ def test_series_assignment(kind, indexer, key):
14521452

14531453
ss_setitem = getattr(ss, indexer) if indexer else ss
14541454

1455-
with tm.assert_produces_warning(PerformanceWarning):
1456-
ss_setitem[key] = 1
1455+
ss_setitem[key] = 1
14571456

14581457
tm.assert_sp_series_equal(ss, res)

0 commit comments

Comments
 (0)