BUG: to_numpy for PandasArray does not handle na_value (#50331)

Author: phofl

doc/source/whatsnew/v2.0.0.rst

@@ -936,7 +936,7 @@ ExtensionArray
 - Bug in :meth:`Series.mean` overflowing unnecessarily with nullable integers (:issue:`48378`)
 - Bug in :meth:`Series.tolist` for nullable dtypes returning numpy scalars instead of python scalars (:issue:`49890`)
 - Bug when concatenating an empty DataFrame with an ExtensionDtype to another DataFrame with the same ExtensionDtype, the resulting dtype turned into object (:issue:`48510`)
--
+- Bug in :meth:`array.PandasArray.to_numpy` raising with ``NA`` value when ``na_value`` is specified (:issue:`40638`)
 
 Styler
 ^^^^^^

pandas/core/arrays/numpy_.py

@@ -389,13 +389,17 @@ def to_numpy(
         copy: bool = False,
         na_value: object = lib.no_default,
     ) -> np.ndarray:
-        result = np.asarray(self._ndarray, dtype=dtype)
+        mask = self.isna()
+        if na_value is not lib.no_default and mask.any():
+            result = self._ndarray.copy()
+            result[mask] = na_value
+        else:
+            result = self._ndarray
 
-        if (copy or na_value is not lib.no_default) and result is self._ndarray:
-            result = result.copy()
+        result = np.asarray(result, dtype=dtype)
 
-        if na_value is not lib.no_default:
-            result[self.isna()] = na_value
+        if copy and result is self._ndarray:
+            result = result.copy()
 
         return result
 

pandas/tests/arrays/test_array.py

@@ -413,3 +413,11 @@ def test_array_not_registered(registry_without_decimal):
     result = pd.array(data, dtype=DecimalDtype)
     expected = DecimalArray._from_sequence(data)
     tm.assert_equal(result, expected)
+
+
+def test_array_to_numpy_na():
+    # GH#40638
+    arr = pd.array([pd.NA, 1], dtype="string")
+    result = arr.to_numpy(na_value=True, dtype=bool)
+    expected = np.array([True, True])
+    tm.assert_numpy_array_equal(result, expected)