Skip to content

Commit ac53246

Browse files
Revert " BUG: RecursionError when attempting to replace np.nan values (#45725) (#45749)" (#46403)
This reverts commit d0a687c.
1 parent 4ff2efc commit ac53246

File tree

3 files changed

+0
-33
lines changed

3 files changed

+0
-33
lines changed

pandas/core/internals/blocks.py

-1
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,6 @@ def replace(
568568
# go through replace_list
569569

570570
values = self.values
571-
value = self._standardize_fill_value(value) # GH#45725
572571

573572
if isinstance(values, Categorical):
574573
# TODO: avoid special-casing

pandas/tests/frame/methods/test_replace.py

-15
Original file line numberDiff line numberDiff line change
@@ -661,21 +661,6 @@ def test_replace_simple_nested_dict_with_nonexistent_value(self):
661661
result = df.replace({"col": {-1: "-", 1: "a", 4: "b"}})
662662
tm.assert_frame_equal(expected, result)
663663

664-
def test_replace_numpy_nan(self, nulls_fixture):
665-
# GH#45725 ensure numpy.nan can be replaced with all other null types
666-
to_replace = np.nan
667-
value = nulls_fixture
668-
dtype = object
669-
df = DataFrame({"A": [to_replace]}, dtype=dtype)
670-
expected = DataFrame({"A": [value]}, dtype=dtype)
671-
672-
result = df.replace({to_replace: value}).astype(dtype=dtype)
673-
tm.assert_frame_equal(result, expected)
674-
675-
# same thing but different calling convention
676-
result = df.replace(to_replace, value).astype(dtype=dtype)
677-
tm.assert_frame_equal(result, expected)
678-
679664
def test_replace_value_is_none(self, datetime_frame):
680665
orig_value = datetime_frame.iloc[0, 0]
681666
orig2 = datetime_frame.iloc[1, 0]

pandas/tests/series/methods/test_replace.py

-17
Original file line numberDiff line numberDiff line change
@@ -36,23 +36,6 @@ def test_replace_explicit_none(self):
3636
assert expected.iloc[-1] is None
3737
tm.assert_series_equal(result, expected)
3838

39-
def test_replace_numpy_nan(self, nulls_fixture):
40-
# GH#45725 ensure numpy.nan can be replaced with all other null types
41-
to_replace = np.nan
42-
value = nulls_fixture
43-
dtype = object
44-
ser = pd.Series([to_replace], dtype=dtype)
45-
expected = pd.Series([value], dtype=dtype)
46-
47-
result = ser.replace({to_replace: value}).astype(dtype=dtype)
48-
tm.assert_series_equal(result, expected)
49-
assert result.dtype == dtype
50-
51-
# same thing but different calling convention
52-
result = ser.replace(to_replace, value).astype(dtype=dtype)
53-
tm.assert_series_equal(result, expected)
54-
assert result.dtype == dtype
55-
5639
def test_replace_noop_doesnt_downcast(self):
5740
# GH#44498
5841
ser = pd.Series([None, None, pd.Timestamp("2021-12-16 17:31")], dtype=object)

0 commit comments

Comments
 (0)