Skip to content

Commit aaca9a7

Browse files
Dont assert functions that assert
assert either raises or doesn't. If it doesn't tm.assert_* returns None, and there's no need to assert XXX is None.
1 parent 15510de commit aaca9a7

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

pandas/tests/indexes/interval/test_interval.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -541,12 +541,12 @@ def test_get_loc_datetimelike_overlapping(self, arrays):
541541
value = index[0].mid + Timedelta('12 hours')
542542
result = np.sort(index.get_loc(value))
543543
expected = np.array([0, 1], dtype='intp')
544-
assert tm.assert_numpy_array_equal(result, expected)
544+
tm.assert_numpy_array_equal(result, expected)
545545

546546
interval = Interval(index[0].left, index[1].right)
547547
result = np.sort(index.get_loc(interval))
548548
expected = np.array([0, 1, 2], dtype='intp')
549-
assert tm.assert_numpy_array_equal(result, expected)
549+
tm.assert_numpy_array_equal(result, expected)
550550

551551
# To be removed, replaced by test_interval_new.py (see #16316, #16386)
552552
def test_get_indexer(self):

pandas/tests/io/parser/test_textreader.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -349,5 +349,5 @@ def test_empty_csv_input(self):
349349

350350
def assert_array_dicts_equal(left, right):
351351
for k, v in compat.iteritems(left):
352-
assert tm.assert_numpy_array_equal(np.asarray(v),
352+
tm.assert_numpy_array_equal(np.asarray(v),
353353
np.asarray(right[k]))

pandas/tests/tools/test_numeric.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ def test_really_large_scalar(large_val, signed, transform, errors):
242242
else:
243243
expected = float(val) if (errors == "coerce" and
244244
val_is_string) else val
245-
assert tm.assert_almost_equal(to_numeric(val, **kwargs), expected)
245+
tm.assert_almost_equal(to_numeric(val, **kwargs), expected)
246246

247247

248248
def test_really_large_in_arr(large_val, signed, transform,

0 commit comments

Comments
 (0)