Skip to content

Commit a89e5de

Browse files
committed
remove typing.cast
1 parent b39ac7a commit a89e5de

File tree

6 files changed

+17
-29
lines changed

6 files changed

+17
-29
lines changed

.pre-commit-config.yaml

-21
Original file line numberDiff line numberDiff line change
@@ -77,27 +77,6 @@ repos:
7777
--linelength=88,
7878
'--filter=-readability/casting,-runtime/int,-build/include_subdir,-readability/fn_size'
7979
]
80-
- repo: https://github.com/pycqa/pylint
81-
rev: v2.16.1
82-
hooks:
83-
- id: pylint
84-
stages: [manual]
85-
- repo: https://github.com/pycqa/pylint
86-
rev: v2.16.1
87-
hooks:
88-
- id: pylint
89-
alias: redefined-outer-name
90-
name: Redefining name from outer scope
91-
files: ^pandas/
92-
exclude: |
93-
(?x)
94-
^pandas/tests # keep excluded
95-
|/_testing/ # keep excluded
96-
|^pandas/util/_test_decorators\.py # keep excluded
97-
|^pandas/_version\.py # keep excluded
98-
|^pandas/conftest\.py # keep excluded
99-
args: [--disable=all, --enable=redefined-outer-name]
100-
stages: [manual]
10180
- repo: https://github.com/PyCQA/isort
10281
rev: 5.12.0
10382
hooks:

pandas/core/frame.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -9931,7 +9931,12 @@ def _series_round(ser: Series, decimals: int) -> Series:
99319931
new_cols = list(_dict_round(self, decimals))
99329932
elif is_integer(decimals):
99339933
# Dispatch to Series.round
9934-
new_cols = [_series_round(v, cast(int, decimals)) for _, v in self.items()]
9934+
# Argument 2 to "_series_round" has incompatible type
9935+
# "Union[int, integer[Any]]"; expected "int"
9936+
new_cols = [
9937+
_series_round(v, decimals) # type: ignore[arg-type]
9938+
for _, v in self.items()
9939+
]
99359940
else:
99369941
raise TypeError("decimals must be an integer, a dict-like or a Series")
99379942

pandas/core/generic.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -4076,8 +4076,8 @@ class animal locomotion
40764076
loc, new_index = index._get_loc_level(key, level=0)
40774077
if not drop_level:
40784078
if lib.is_integer(loc):
4079-
loc = cast(int, loc)
4080-
new_index = index[loc : loc + 1]
4079+
# Slice index must be an integer or None
4080+
new_index = index[loc : loc + 1] # type: ignore[misc]
40814081
else:
40824082
new_index = index[loc]
40834083
else:

pandas/core/indexes/multi.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -2918,8 +2918,8 @@ def get_loc_level(self, key, level: IndexLabel = 0, drop_level: bool = True):
29182918
loc, mi = self._get_loc_level(key, level=level)
29192919
if not drop_level:
29202920
if lib.is_integer(loc):
2921-
loc = cast(int, loc)
2922-
mi = self[loc : loc + 1]
2921+
# Slice index must be an integer or None
2922+
mi = self[loc : loc + 1] # type: ignore[misc]
29232923
else:
29242924
mi = self[loc]
29252925
return loc, mi

pandas/core/reshape/concat.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,8 @@ class _Concatenator:
388388
Orchestrates a concatenation operation for BlockManagers
389389
"""
390390

391+
sort: bool
392+
391393
def __init__(
392394
self,
393395
objs: Iterable[NDFrame] | Mapping[HashableT, NDFrame],
@@ -552,7 +554,9 @@ def __init__(
552554
raise ValueError(
553555
f"The 'sort' keyword only accepts boolean values; {sort} was passed."
554556
)
555-
self.sort = cast(bool, sort)
557+
# Incompatible types in assignment (expression has type "Union[bool, bool_]",
558+
# variable has type "bool")
559+
self.sort = sort # type: ignore[assignment]
556560

557561
self.ignore_index = ignore_index
558562
self.verify_integrity = verify_integrity

pandas/io/parsers/python_parser.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1345,8 +1345,8 @@ def _validate_skipfooter_arg(skipfooter: int) -> int:
13451345
if not is_integer(skipfooter):
13461346
raise ValueError("skipfooter must be an integer")
13471347

1348-
skipfooter = cast(int, skipfooter)
13491348
if skipfooter < 0:
13501349
raise ValueError("skipfooter cannot be negative")
13511350

1352-
return skipfooter
1351+
# Incompatible return value type (got "Union[int, integer[Any]]", expected "int")
1352+
return skipfooter # type: ignore[return-value]

0 commit comments

Comments
 (0)