Skip to content

Commit a61badd

Browse files
committed
Finished up decorator cleanup for reads, linted
1 parent f89cdc2 commit a61badd

File tree

1 file changed

+29
-31
lines changed

1 file changed

+29
-31
lines changed

pandas/tests/io/test_excel.py

+29-31
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ def test_usecols_int(self, ext):
134134
dfref = self.get_csv_refdf('test1')
135135
dfref = dfref.reindex(columns=['A', 'B', 'C'])
136136
df1 = self.get_exceldf('test1', ext, 'Sheet1', index_col=0, usecols=3)
137-
df2 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1], index_col=0,
138-
usecols=3)
137+
df2 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1],
138+
index_col=0, usecols=3)
139139

140140
with tm.assert_produces_warning(FutureWarning):
141141
df3 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1],
@@ -152,8 +152,8 @@ def test_usecols_list(self, ext):
152152
dfref = dfref.reindex(columns=['B', 'C'])
153153
df1 = self.get_exceldf('test1', ext, 'Sheet1', index_col=0,
154154
usecols=[0, 2, 3])
155-
df2 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1], index_col=0,
156-
usecols=[0, 2, 3])
155+
df2 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1],
156+
index_col=0, usecols=[0, 2, 3])
157157

158158
with tm.assert_produces_warning(FutureWarning):
159159
df3 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1],
@@ -171,8 +171,8 @@ def test_usecols_str(self, ext):
171171
df1 = dfref.reindex(columns=['A', 'B', 'C'])
172172
df2 = self.get_exceldf('test1', ext, 'Sheet1', index_col=0,
173173
usecols='A:D')
174-
df3 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1], index_col=0,
175-
usecols='A:D')
174+
df3 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1],
175+
index_col=0, usecols='A:D')
176176

177177
with tm.assert_produces_warning(FutureWarning):
178178
df4 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1],
@@ -277,7 +277,8 @@ def test_excel_table(self, ext):
277277
dfref = self.get_csv_refdf('test1')
278278

279279
df1 = self.get_exceldf('test1', ext, 'Sheet1', index_col=0)
280-
df2 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1], index_col=0)
280+
df2 = self.get_exceldf('test1', ext, 'Sheet2', skiprows=[1],
281+
index_col=0)
281282
# TODO add index to file
282283
tm.assert_frame_equal(df1, dfref, check_names=False)
283284
tm.assert_frame_equal(df2, dfref, check_names=False)
@@ -350,7 +351,8 @@ def test_reader_converters(self, ext):
350351

351352
# should read in correctly and set types of single cells (not array
352353
# dtypes)
353-
actual = self.get_exceldf(basename, ext, 'Sheet1', converters=converters)
354+
actual = self.get_exceldf(basename, ext, 'Sheet1',
355+
converters=converters)
354356
tm.assert_frame_equal(actual, expected)
355357

356358
def test_reader_dtype(self, ext):
@@ -426,11 +428,10 @@ def test_read_excel_blank_with_header(self, ext):
426428
actual = self.get_exceldf('blank_with_header', ext, 'Sheet1')
427429
tm.assert_frame_equal(actual, expected)
428430

431+
@td.skip_if_no('openpyxl')
432+
@td.skip_if_no('xlwt')
429433
# GH 12292 : error when read one empty column from excel file
430434
def test_read_one_empty_col_no_header(self, ext):
431-
_skip_if_no_xlwt()
432-
_skip_if_no_openpyxl()
433-
434435
df = pd.DataFrame(
435436
[["", 1, 100],
436437
["", 2, 200],
@@ -456,10 +457,9 @@ def test_read_one_empty_col_no_header(self, ext):
456457
tm.assert_frame_equal(actual_header_none, expected)
457458
tm.assert_frame_equal(actual_header_zero, expected)
458459

460+
@td.skip_if_no('openpyxl')
461+
@td.skip_if_no('xlwt')
459462
def test_read_one_empty_col_with_header(self, ext):
460-
_skip_if_no_xlwt()
461-
_skip_if_no_openpyxl()
462-
463463
df = pd.DataFrame(
464464
[["", 1, 100],
465465
["", 2, 200],
@@ -486,10 +486,9 @@ def test_read_one_empty_col_with_header(self, ext):
486486
expected_header_zero = DataFrame(columns=[0], dtype='int64')
487487
tm.assert_frame_equal(actual_header_zero, expected_header_zero)
488488

489+
@td.skip_if_no('openpyxl')
490+
@td.skip_if_no('xlwt')
489491
def test_set_column_names_in_parameter(self, ext):
490-
_skip_if_no_xlwt()
491-
_skip_if_no_openpyxl()
492-
493492
# GH 12870 : pass down column names associated with
494493
# keyword argument names
495494
refdf = pd.DataFrame([[1, 'foo'], [2, 'bar'],
@@ -529,14 +528,16 @@ def test_sheet_name_and_sheetname(self, ext):
529528
dfref = self.get_csv_refdf('test1')
530529
df1 = self.get_exceldf('test1', ext, sheet_name='Sheet1') # doc
531530
with tm.assert_produces_warning(FutureWarning, check_stacklevel=False):
532-
df2 = self.get_exceldf('test1', ext, sheetname='Sheet1') # bkwrd compat
531+
df2 = self.get_exceldf('test1', ext,
532+
sheetname='Sheet1') # bkwrd compat
533533

534534
tm.assert_frame_equal(df1, dfref, check_names=False)
535535
tm.assert_frame_equal(df2, dfref, check_names=False)
536536

537537
def test_sheet_name_both_raises(self, ext):
538538
with tm.assert_raises_regex(TypeError, "Cannot specify both"):
539-
self.get_exceldf('test1', ext, sheetname='Sheet1', sheet_name='Sheet1')
539+
self.get_exceldf('test1', ext, sheetname='Sheet1',
540+
sheet_name='Sheet1')
540541

541542

542543
@pytest.mark.parametrize("ext", ['.xls', '.xlsx', '.xlsm'])
@@ -559,9 +560,8 @@ def test_excel_read_buffer(self, ext):
559560
actual = read_excel(xls, 'Sheet1', index_col=0)
560561
tm.assert_frame_equal(expected, actual)
561562

563+
@td.skip_if_no('xlwt')
562564
def test_read_xlrd_Book(self, ext):
563-
_skip_if_no_xlwt()
564-
565565
df = self.frame
566566
with ensure_clean('.xls') as pth:
567567
df.to_excel(pth, "SheetA")
@@ -659,14 +659,12 @@ def test_reader_closes_file(self, ext):
659659

660660
assert f.closed
661661

662+
@td.skip_if_no('openpyxl')
663+
@td.skip_if_no('xlwt')
662664
def test_creating_and_reading_multiple_sheets(self, ext):
663665
# Test reading multiple sheets, from a runtime created excel file
664666
# with multiple sheets.
665667
# See PR #9450
666-
667-
_skip_if_no_xlwt()
668-
_skip_if_no_openpyxl()
669-
670668
def tdf(sheetname):
671669
d, i = [11, 22, 33], [1, 2, 3]
672670
return DataFrame(d, i, columns=[sheetname])
@@ -778,9 +776,9 @@ def test_read_excel_multiindex(self, ext):
778776
header=[0, 1], skiprows=2)
779777
tm.assert_frame_equal(actual, expected)
780778

779+
@td.skip_if_no('xlsxwriter')
781780
def test_read_excel_multiindex_empty_level(self, ext):
782781
# GH 12453
783-
_skip_if_no_xlsxwriter()
784782
with ensure_clean('.xlsx') as path:
785783
df = DataFrame({
786784
('Zero', ''): {0: 0},
@@ -818,9 +816,9 @@ def test_read_excel_multiindex_empty_level(self, ext):
818816
actual = pd.read_excel(path, header=[0, 1])
819817
tm.assert_frame_equal(actual, expected)
820818

819+
@td.skip_if_no('xlsxwriter')
821820
def test_excel_multindex_roundtrip(self, ext):
822821
# GH 4679
823-
_skip_if_no_xlsxwriter()
824822
with ensure_clean('.xlsx') as pth:
825823
for c_idx_names in [True, False]:
826824
for r_idx_names in [True, False]:
@@ -937,11 +935,10 @@ def test_read_excel_chunksize(self, ext):
937935
pd.read_excel(os.path.join(self.dirpath, 'test1' + ext),
938936
chunksize=100)
939937

938+
@td.skip_if_no('openpyxl')
939+
@td.skip_if_no('xlwt')
940940
def test_read_excel_parse_dates(self, ext):
941941
# GH 11544, 12051
942-
_skip_if_no_openpyxl()
943-
_skip_if_no_xlwt() # for df2.to_excel
944-
945942
df = DataFrame(
946943
{'col': [1, 2, 3],
947944
'date_strings': pd.date_range('2012-01-01', periods=3)})
@@ -1707,7 +1704,8 @@ def roundtrip(df, header=True, parser_hdr=0, index=True):
17071704
assert res.shape == (1, 2)
17081705
assert res.iloc[0, 0] is not np.nan
17091706

1710-
def test_excel_010_hemstring_raises_NotImplementedError(self, merge_cells, engine, ext):
1707+
def test_excel_010_hemstring_raises_NotImplementedError(self, merge_cells,
1708+
engine,ext):
17111709
# This test was failing only for j>1 and header=False,
17121710
# So I reproduced a simple test.
17131711
if merge_cells:

0 commit comments

Comments
 (0)