Skip to content

Commit a3bcbd1

Browse files
committed
TST/BUG: Ensure pathlib roundtrip uses right params
Reader / writer may depend on filename and engine. Set these on the reader and writer before round-tripping.
1 parent 11bed21 commit a3bcbd1

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

pandas/tests/io/test_excel.py

+10-3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import sys
66
import os
77
from distutils.version import LooseVersion
8+
from functools import partial
89

910
import warnings
1011
from warnings import catch_warnings
@@ -551,7 +552,7 @@ def test_sheet_name_and_sheetname(self):
551552
dfref = self.get_csv_refdf('test1')
552553
df1 = self.get_exceldf('test1', sheet_name='Sheet1') # doc
553554
with tm.assert_produces_warning(FutureWarning, check_stacklevel=False):
554-
df2 = self.get_exceldf('test1', sheetname='Sheet2') # bkwrd compat
555+
df2 = self.get_exceldf('test1', sheetname='Sheet1') # bkwrd compat
555556

556557
tm.assert_frame_equal(df1, dfref, check_names=False)
557558
tm.assert_frame_equal(df2, dfref, check_names=False)
@@ -1876,12 +1877,18 @@ def test_freeze_panes(self):
18761877

18771878
def test_path_pathlib(self):
18781879
df = tm.makeDataFrame()
1879-
result = tm.round_trip_pathlib(df.to_excel, pd.read_excel)
1880+
writer = partial(df.to_excel, engine=self.engine_name)
1881+
reader = partial(pd.read_excel)
1882+
result = tm.round_trip_pathlib(writer, reader,
1883+
path="foo.{}".format(self.ext))
18801884
tm.assert_frame_equal(df, result)
18811885

18821886
def test_path_localpath(self):
18831887
df = tm.makeDataFrame()
1884-
result = tm.round_trip_localpath(df.to_excel, pd.read_excel)
1888+
writer = partial(df.to_excel, engine=self.engine_name)
1889+
reader = partial(pd.read_excel)
1890+
result = tm.round_trip_pathlib(writer, reader,
1891+
path="foo.{}".format(self.ext))
18851892
tm.assert_frame_equal(df, result)
18861893

18871894

0 commit comments

Comments
 (0)