@@ -70,12 +70,12 @@ def test_cummin_cummax(self, datetime_series, method):
70
70
[
71
71
"cummax" ,
72
72
False ,
73
- ["NaT" , "2 days " , "2 days " , "2 days " , "2 days " , "3 days " ],
73
+ ["NaT" , "NaT " , "NaT " , "NaT " , "NaT " , "NaT " ],
74
74
],
75
75
[
76
76
"cummin" ,
77
77
False ,
78
- ["NaT" , "2 days " , "2 days " , "1 days " , "1 days " , "1 days " ],
78
+ ["NaT" , "NaT " , "NaT " , "NaT " , "NaT " , "NaT " ],
79
79
],
80
80
],
81
81
)
@@ -91,6 +91,26 @@ def test_cummin_cummax_datetimelike(self, ts, method, skipna, exp_tdi):
91
91
result = getattr (ser , method )(skipna = skipna )
92
92
tm .assert_series_equal (expected , result )
93
93
94
+ @pytest .mark .parametrize (
95
+ "func, exp" ,
96
+ [
97
+ ("cummin" , pd .Period ("2012-1-1" , freq = "D" )),
98
+ ("cummax" , pd .Period ("2012-1-2" , freq = "D" )),
99
+ ],
100
+ )
101
+ def test_cummin_cummax_period (self , func , exp ):
102
+ # GH#28385
103
+ ser = pd .Series (
104
+ [pd .Period ("2012-1-1" , freq = "D" ), pd .NaT , pd .Period ("2012-1-2" , freq = "D" )]
105
+ )
106
+ result = getattr (ser , func )(skipna = False )
107
+ expected = pd .Series ([pd .Period ("2012-1-1" , freq = "D" ), pd .NaT , pd .NaT ])
108
+ tm .assert_series_equal (result , expected )
109
+
110
+ result = getattr (ser , func )(skipna = True )
111
+ expected = pd .Series ([pd .Period ("2012-1-1" , freq = "D" ), pd .NaT , exp ])
112
+ tm .assert_series_equal (result , expected )
113
+
94
114
@pytest .mark .parametrize (
95
115
"arg" ,
96
116
[
0 commit comments