TYP: annotate tseries.holiday (#35913)

Author: jbrockmendel

pandas/tseries/holiday.py

@@ -12,7 +12,7 @@
 from pandas.tseries.offsets import Day, Easter
 
 
-def next_monday(dt):
+def next_monday(dt: datetime) -> datetime:
     """
     If holiday falls on Saturday, use following Monday instead;
     if holiday falls on Sunday, use Monday instead
@@ -24,7 +24,7 @@ def next_monday(dt):
     return dt
 
 
-def next_monday_or_tuesday(dt):
+def next_monday_or_tuesday(dt: datetime) -> datetime:
     """
     For second holiday of two adjacent ones!
     If holiday falls on Saturday, use following Monday instead;
@@ -39,7 +39,7 @@ def next_monday_or_tuesday(dt):
     return dt
 
 
-def previous_friday(dt):
+def previous_friday(dt: datetime) -> datetime:
     """
     If holiday falls on Saturday or Sunday, use previous Friday instead.
     """
@@ -50,7 +50,7 @@ def previous_friday(dt):
     return dt
 
 
-def sunday_to_monday(dt):
+def sunday_to_monday(dt: datetime) -> datetime:
     """
     If holiday falls on Sunday, use day thereafter (Monday) instead.
     """
@@ -59,7 +59,7 @@ def sunday_to_monday(dt):
     return dt
 
 
-def weekend_to_monday(dt):
+def weekend_to_monday(dt: datetime) -> datetime:
     """
     If holiday falls on Sunday or Saturday,
     use day thereafter (Monday) instead.
@@ -72,7 +72,7 @@ def weekend_to_monday(dt):
     return dt
 
 
-def nearest_workday(dt):
+def nearest_workday(dt: datetime) -> datetime:
     """
     If holiday falls on Saturday, use day before (Friday) instead;
     if holiday falls on Sunday, use day thereafter (Monday) instead.
@@ -84,7 +84,7 @@ def nearest_workday(dt):
     return dt
 
 
-def next_workday(dt):
+def next_workday(dt: datetime) -> datetime:
     """
     returns next weekday used for observances
     """
@@ -95,7 +95,7 @@ def next_workday(dt):
     return dt
 
 
-def previous_workday(dt):
+def previous_workday(dt: datetime) -> datetime:
     """
     returns previous weekday used for observances
     """
@@ -106,14 +106,14 @@ def previous_workday(dt):
     return dt
 
 
-def before_nearest_workday(dt):
+def before_nearest_workday(dt: datetime) -> datetime:
     """
     returns previous workday after nearest workday
     """
     return previous_workday(nearest_workday(dt))
 
 
-def after_nearest_workday(dt):
+def after_nearest_workday(dt: datetime) -> datetime:
     """
     returns next workday after nearest workday
     needed for Boxing day or multiple holidays in a series
@@ -428,9 +428,11 @@ def holidays(self, start=None, end=None, return_name=False):
         # If we don't have a cache or the dates are outside the prior cache, we
         # get them again
         if self._cache is None or start < self._cache[0] or end > self._cache[1]:
-            holidays = [rule.dates(start, end, return_name=True) for rule in self.rules]
-            if holidays:
-                holidays = concat(holidays)
+            pre_holidays = [
+                rule.dates(start, end, return_name=True) for rule in self.rules
+            ]
+            if pre_holidays:
+                holidays = concat(pre_holidays)
             else:
                 holidays = Series(index=DatetimeIndex([]), dtype=object)
 

setup.cfg

@@ -276,6 +276,3 @@ check_untyped_defs=False
 
 [mypy-pandas.plotting._matplotlib.misc]
 check_untyped_defs=False
-
-[mypy-pandas.tseries.holiday]
-check_untyped_defs=False