review fixes: versionadded, issue links, repr tests, legacy

Author: thejohnfreeman

doc/source/whatsnew/v0.18.2.txt

@@ -38,7 +38,7 @@ Other enhancements
      idx = pd.Index(["a1a2", "b1", "c1"])
      idx.str.extractall("[ab](?P<digit>\d)")
 
-- ``Timestamp``s can now accept positional parameters like :func:`datetime.datetime`:
+- ``Timestamp``s can now accept positional and keyword parameters like :func:`datetime.datetime` (:issue:`10758`, :issue:`11630`)
 
   .. ipython:: python
 

pandas/tseries/tests/test_tslib.py

@@ -193,16 +193,14 @@ def test_constructor_positional(self):
         with tm.assertRaises(ValueError):
             Timestamp(2000, 1, 32)
 
-        ts = Timestamp(2000, 1, 2)
-
-        actual = ts.to_pydatetime()
-        expected = datetime.datetime(2000, 1, 2)
-        self.assertEqual(actual, expected)
-        self.assertEqual(type(actual), type(expected))
+        # GH 11630
+        self.assertEqual(
+                repr(Timestamp(2015, 11, 12)),
+                repr(Timestamp('20151112')))
 
-        pos_args = [2000, 1, 2, 3, 4, 5, 999999]
-        self.assertEqual(Timestamp(*pos_args).to_pydatetime(),
-                         datetime.datetime(*pos_args))
+        self.assertEqual(
+                repr(Timestamp(2015, 11, 12, 1, 2, 3, 999999)),
+                repr(Timestamp('2015-11-12 01:02:03.999999')))
 
     def test_constructor_keyword(self):
         # GH 10758
@@ -217,25 +215,14 @@ def test_constructor_keyword(self):
         with tm.assertRaises(ValueError):
             Timestamp(year=2000, month=1, day=32)
 
-        ts = Timestamp(year=2000, month=1, day=2)
-
-        actual = ts.to_pydatetime()
-        expected = datetime.datetime(year=2000, month=1, day=2)
-        self.assertEqual(actual, expected)
-        self.assertEqual(type(actual), type(expected))
-
-        pos_args = [2000, 1, 2, 3, 4, 5, 999999]
-        kw_args = {
-                'year': 2000,
-                'month': 1,
-                'day': 2,
-                'hour': 3,
-                'minute': 4,
-                'second': 5,
-                'microsecond': 999999,
-                }
-        self.assertEqual(Timestamp(**kw_args).to_pydatetime(),
-                         datetime.datetime(**kw_args))
+        self.assertEqual(
+                repr(Timestamp(year=2015, month=11, day=12)),
+                repr(Timestamp('20151112')))
+
+        self.assertEqual(
+                repr(Timestamp(year=2015, month=11, day=12,
+                    hour=1, minute=2, second=3, microsecond=999999)),
+                repr(Timestamp('2015-11-12 01:02:03.999999')))
 
     def test_conversion(self):
         # GH 9255

pandas/tslib.pyx

@@ -226,10 +226,10 @@ class Timestamp(_Timestamp):
     oriented data structures in pandas.
 
     There are essentially three calling conventions for the constructor. The
-    first, legacy form accepts four parameters. They can be passed by
-    position or keyword.
+    primary form accepts four parameters. They can be passed by position or
+    keyword.
 
-    Legacy Parameters
+    Parameters
     -----------------
     ts_input : datetime-like, str, int, float
         Value to be converted to Timestamp
@@ -243,8 +243,11 @@ class Timestamp(_Timestamp):
     The other two forms copy the parameters from datetime.datetime. They can
     be passed by either position or keyword, but not both mixed together.
 
-    datetime.datetime Parameters
+    :func:`datetime.datetime` Parameters
     ------------------------------
+
+    .. versionadded:: 0.18.2
+
     year : int
     month : int
     day : int