TYP/CI: bump mypy&pyright (#46905)

Author: twoertwein

.github/workflows/code-checks.yml

@@ -74,7 +74,7 @@ jobs:
 
     - name: Install pyright
       # note: keep version in sync with .pre-commit-config.yaml
-      run: npm install -g [email protected].245
+      run: npm install -g [email protected].247
 
     - name: Build Pandas
       id: build

.pre-commit-config.yaml

@@ -89,7 +89,7 @@ repos:
         types: [python]
         stages: [manual]
         # note: keep version in sync with .github/workflows/code-checks.yml
-        additional_dependencies: ['[email protected].245']
+        additional_dependencies: ['[email protected].247']
 -   repo: local
     hooks:
     -   id: flake8-rst

doc/source/whatsnew/v1.5.0.rst

@@ -360,7 +360,7 @@ If installed, we now require:
 +-----------------+-----------------+----------+---------+
 | Package         | Minimum Version | Required | Changed |
 +=================+=================+==========+=========+
-| mypy (dev)      | 0.941           |          |    X    |
+| mypy (dev)      | 0.950           |          |    X    |
 +-----------------+-----------------+----------+---------+
 
 

environment.yml

@@ -24,7 +24,7 @@ dependencies:
   - flake8-bugbear=21.3.2  # used by flake8, find likely bugs
   - flake8-comprehensions=3.7.0  # used by flake8, linting of unnecessary comprehensions
   - isort>=5.2.1  # check that imports are in the right order
-  - mypy=0.941
+  - mypy=0.950
   - pre-commit>=2.9.2
   - pycodestyle  # used by flake8
   - pyupgrade

pandas/_config/localization.py

@@ -45,7 +45,9 @@ def set_locale(
         locale.setlocale(lc_var, new_locale)
         normalized_locale = locale.getlocale()
         if all(x is not None for x in normalized_locale):
-            yield ".".join(normalized_locale)
+            # error: Argument 1 to "join" of "str" has incompatible type
+            # "Tuple[Optional[str], Optional[str]]"; expected "Iterable[str]"
+            yield ".".join(normalized_locale)  # type: ignore[arg-type]
         else:
             yield new_locale
     finally:

pandas/_libs/tslibs/timestamps.pyi

@@ -113,7 +113,7 @@ class Timestamp(datetime):
     def time(self) -> _time: ...
     def timetz(self) -> _time: ...
     def replace(
-        self,
+        self: _DatetimeT,
         year: int = ...,
         month: int = ...,
         day: int = ...,
@@ -123,7 +123,7 @@ class Timestamp(datetime):
         microsecond: int = ...,
         tzinfo: _tzinfo | None = ...,
         fold: int = ...,
-    ) -> datetime: ...
+    ) -> _DatetimeT: ...
     def astimezone(self: _DatetimeT, tz: _tzinfo | None = ...) -> _DatetimeT: ...
     def ctime(self) -> str: ...
     def isoformat(self, sep: str = ..., timespec: str = ...) -> str: ...

pandas/core/arrays/masked.py

@@ -957,7 +957,7 @@ def equals(self, other) -> bool:
         return array_equivalent(left, right, dtype_equal=True)
 
     def _quantile(
-        self: BaseMaskedArrayT, qs: npt.NDArray[np.float64], interpolation: str
+        self, qs: npt.NDArray[np.float64], interpolation: str
     ) -> BaseMaskedArray:
         """
         Dispatch to quantile_with_mask, needed because we do not have

pandas/io/parsers/base_parser.py

@@ -7,6 +7,7 @@
 from enum import Enum
 import itertools
 from typing import (
+    Any,
     Callable,
     DefaultDict,
     Hashable,
@@ -1027,26 +1028,14 @@ def _get_empty_meta(
         # Convert `dtype` to a defaultdict of some kind.
         # This will enable us to write `dtype[col_name]`
         # without worrying about KeyError issues later on.
+        dtype_dict: defaultdict[Hashable, Any]
         if not is_dict_like(dtype):
             # if dtype == None, default will be object.
             default_dtype = dtype or object
-            # error: Argument 1 to "defaultdict" has incompatible type "Callable[[],
-            # Union[ExtensionDtype, str, dtype[Any], Type[object], Dict[Hashable,
-            # Union[ExtensionDtype, Union[str, dtype[Any]], Type[str], Type[float],
-            # Type[int], Type[complex], Type[bool], Type[object]]]]]"; expected
-            # "Optional[Callable[[], Union[ExtensionDtype, str, dtype[Any],
-            # Type[object]]]]"
-            # error: Incompatible return value type (got "Union[ExtensionDtype, str,
-            # dtype[Any], Type[object], Dict[Hashable, Union[ExtensionDtype, Union[str,
-            # dtype[Any]], Type[str], Type[float], Type[int], Type[complex], Type[bool],
-            # Type[object]]]]", expected "Union[ExtensionDtype, str, dtype[Any],
-            # Type[object]]")
-            dtype = defaultdict(
-                lambda: default_dtype  # type: ignore[arg-type, return-value]
-            )
+            dtype_dict = defaultdict(lambda: default_dtype)
         else:
             dtype = cast(dict, dtype)
-            dtype = defaultdict(
+            dtype_dict = defaultdict(
                 lambda: object,
                 {columns[k] if is_integer(k) else k: v for k, v in dtype.items()},
             )
@@ -1063,14 +1052,16 @@ def _get_empty_meta(
         if (index_col is None or index_col is False) or index_names is None:
             index = Index([])
         else:
-            data = [Series([], dtype=dtype[name]) for name in index_names]
+            data = [Series([], dtype=dtype_dict[name]) for name in index_names]
             index = ensure_index_from_sequences(data, names=index_names)
             index_col.sort()
 
             for i, n in enumerate(index_col):
                 columns.pop(n - i)
 
-        col_dict = {col_name: Series([], dtype=dtype[col_name]) for col_name in columns}
+        col_dict = {
+            col_name: Series([], dtype=dtype_dict[col_name]) for col_name in columns
+        }
 
         return index, columns, col_dict
 

requirements-dev.txt

@@ -12,7 +12,7 @@ flake8==4.0.1
 flake8-bugbear==21.3.2
 flake8-comprehensions==3.7.0
 isort>=5.2.1
-mypy==0.941
+mypy==0.950
 pre-commit>=2.9.2
 pycodestyle
 pyupgrade