Skip to content

Commit 8d4711d

Browse files
committed
BUG: sort_index throws IndexError for some permutations (#26053)
- (lev - i) will be out of bounds for pop if the first index dim is to be sorted last
1 parent e02ec8f commit 8d4711d

File tree

2 files changed

+29
-6
lines changed

2 files changed

+29
-6
lines changed

pandas/core/indexes/multi.py

+8-2
Original file line numberDiff line numberDiff line change
@@ -2085,8 +2085,14 @@ def sortlevel(self, level=0, ascending=True, sort_remaining=True):
20852085
shape = list(self.levshape)
20862086

20872087
# partition codes and shape
2088-
primary = tuple(codes.pop(lev - i) for i, lev in enumerate(level))
2089-
primshp = tuple(shape.pop(lev - i) for i, lev in enumerate(level))
2088+
primary = tuple(codes[lev] for lev in level)
2089+
primshp = tuple(shape[lev] for lev in level)
2090+
2091+
# Reverse sorted to retain the order of
2092+
# smaller indices that needs to be removed
2093+
for lev in sorted(level, reverse=True):
2094+
codes.pop(lev)
2095+
shape.pop(lev)
20902096

20912097
if sort_remaining:
20922098
primary += primary + tuple(codes)

pandas/tests/frame/test_sorting.py

+21-4
Original file line numberDiff line numberDiff line change
@@ -496,11 +496,28 @@ def test_sort_index_duplicates(self):
496496
def test_sort_index_level(self):
497497
mi = MultiIndex.from_tuples([[1, 1, 3], [1, 1, 1]], names=list('ABC'))
498498
df = DataFrame([[1, 2], [3, 4]], mi)
499-
res = df.sort_index(level='A', sort_remaining=False)
500-
assert_frame_equal(df, res)
501499

502-
res = df.sort_index(level=['A', 'B'], sort_remaining=False)
503-
assert_frame_equal(df, res)
500+
result = df.sort_index(level='A', sort_remaining=False)
501+
expected = df
502+
assert_frame_equal(result, expected)
503+
504+
result = df.sort_index(level=['A', 'B'], sort_remaining=False)
505+
expected = df
506+
assert_frame_equal(result, expected)
507+
508+
# Error thrown by sort_index when
509+
# first index is sorted last (#26053)
510+
result = df.sort_index(level=['C', 'B', 'A'])
511+
expected = df.iloc[[1, 0]]
512+
assert_frame_equal(result, expected)
513+
514+
result = df.sort_index(level=['B', 'C', 'A'])
515+
expected = df.iloc[[1, 0]]
516+
assert_frame_equal(result, expected)
517+
518+
result = df.sort_index(level=['C', 'A'])
519+
expected = df.iloc[[1, 0]]
520+
assert_frame_equal(result, expected)
504521

505522
def test_sort_index_categorical_index(self):
506523

0 commit comments

Comments
 (0)