REF: removed unused convert keyword

Author: jbrockmendel

pandas/core/arrays/string_.py

@@ -350,9 +350,7 @@ def _str_map(
         self, f, na_value=None, dtype: Dtype | None = None, convert: bool = True
     ):
         if self.dtype.na_value is np.nan:
-            return self._str_map_nan_semantics(
-                f, na_value=na_value, dtype=dtype, convert=convert
-            )
+            return self._str_map_nan_semantics(f, na_value=na_value, dtype=dtype)
 
         from pandas.arrays import BooleanArray
 
@@ -395,7 +393,7 @@ def _str_map(
             return constructor(result, mask)
 
         else:
-            return self._str_map_str_or_object(dtype, na_value, arr, f, mask, convert)
+            return self._str_map_str_or_object(dtype, na_value, arr, f, mask)
 
     def _str_map_str_or_object(
         self,
@@ -404,7 +402,6 @@ def _str_map_str_or_object(
         arr: np.ndarray,
         f,
         mask: npt.NDArray[np.bool_],
-        convert: bool,
     ):
         # _str_map helper for case where dtype is either string dtype or object
         if is_string_dtype(dtype) and not is_object_dtype(dtype):
@@ -428,17 +425,14 @@ def _str_map_str_or_object(
             # -> We don't know the result type. E.g. `.get` can return anything.
             return lib.map_infer_mask(arr, f, mask.view("uint8"))
 
-    def _str_map_nan_semantics(
-        self, f, na_value=None, dtype: Dtype | None = None, convert: bool = True
-    ):
+    def _str_map_nan_semantics(self, f, na_value=None, dtype: Dtype | None = None):
         if dtype is None:
             dtype = self.dtype
         if na_value is None:
             na_value = self.dtype.na_value
 
         mask = isna(self)
         arr = np.asarray(self)
-        convert = convert and not np.all(mask)
 
         if is_integer_dtype(dtype) or is_bool_dtype(dtype):
             na_value_is_na = isna(na_value)
@@ -465,7 +459,7 @@ def _str_map_nan_semantics(
             return result
 
         else:
-            return self._str_map_str_or_object(dtype, na_value, arr, f, mask, convert)
+            return self._str_map_str_or_object(dtype, na_value, arr, f, mask)
 
 
 # error: Definition of "_concat_same_type" in base class "NDArrayBacked" is

pandas/core/arrays/string_arrow.py

@@ -281,9 +281,7 @@ def astype(self, dtype, copy: bool = True):
 
     _str_map = BaseStringArray._str_map
 
-    def _str_map_nan_semantics(
-        self, f, na_value=None, dtype: Dtype | None = None, convert: bool = True
-    ):
+    def _str_map_nan_semantics(self, f, na_value=None, dtype: Dtype | None = None):
         if dtype is None:
             dtype = self.dtype
         if na_value is None:
@@ -318,7 +316,7 @@ def _str_map_nan_semantics(
             return result
 
         else:
-            return self._str_map_str_or_object(dtype, na_value, arr, f, mask, convert)
+            return self._str_map_str_or_object(dtype, na_value, arr, f, mask)
 
     def _str_contains(
         self, pat, case: bool = True, flags: int = 0, na=np.nan, regex: bool = True