Fix #17965 to allow full comparison of datetimelike objects

Author: watercrossing

doc/source/whatsnew/v0.21.1.txt

@@ -61,6 +61,7 @@ Bug Fixes
 - Bug in :class:`DatetimeIndex` subtracting datetimelike from DatetimeIndex could fail to overflow (:issue:`18020`)
 - Bug in ``pd.Series.rolling.skew()`` and ``rolling.kurt()`` with all equal values has floating issue (:issue:`18044`)
 - Bug in ``pd.DataFrameGroupBy.count()`` when counting over a datetimelike column (:issue:`13393`)
+- Bug in ``_libs.index.convert_scalar()``: Comparison between ``datetime64[ns]`` series and ``datetimelike`` (:issue:`17965`)
 
 Conversion
 ^^^^^^^^^^

pandas/_libs/index.pyx

@@ -19,7 +19,7 @@ from hashtable cimport HashTable
 
 from pandas._libs import algos, period as periodlib, hashtable as _hash
 from pandas._libs.tslib import Timestamp, Timedelta
-from datetime import datetime, timedelta
+from datetime import datetime, timedelta, date
 
 from cpython cimport PyTuple_Check, PyList_Check
 
@@ -549,7 +549,7 @@ cpdef convert_scalar(ndarray arr, object value):
     if arr.descr.type_num == NPY_DATETIME:
         if isinstance(value, np.ndarray):
             pass
-        elif isinstance(value, datetime):
+        elif isinstance(value, (np.datetime64, datetime, date)):
             return Timestamp(value).value
         elif value is None or value != value:
             return iNaT

pandas/tests/indexes/datetimes/test_partial_slicing.py

@@ -5,6 +5,8 @@
 from datetime import datetime
 import numpy as np
 import pandas as pd
+from itertools import product
+import operator as op
 
 from pandas import (DatetimeIndex, Series, DataFrame,
                     date_range, Index, Timedelta, Timestamp)
@@ -330,3 +332,23 @@ def test_loc_datetime_length_one(self):
 
         result = df.loc['2016-10-01T00:00:00':]
         tm.assert_frame_equal(result, df)
+
+    comparisonTS = Timestamp('20130101')
+
+    @pytest.mark.parametrize('datetimelike,opExp', product(
+        [comparisonTS, comparisonTS.to_pydatetime(),
+         comparisonTS.to_pydatetime().date(), comparisonTS.to_datetime64()],
+        [(op.lt, [True, False, False, False]),
+         (op.le, [True, True, False, False]),
+         (op.eq, [False, True, False, False]),
+         (op.gt, [False, False, False, True])]))
+    def test_selection_by_datetimelike(self, datetimelike, opExp):
+        # GH issue #17965, test for ability to compare datetime64[ns] columns
+        # to datetimelike
+        op, exp = opExp
+        df = DataFrame({'A': [pd.Timestamp('20120101'),
+                              pd.Timestamp('20130101'),
+                              np.nan, pd.Timestamp('20130103')]})
+        result = op(df.A, datetimelike)
+        expected = Series(exp, name='A')
+        tm.assert_series_equal(result, expected)